[17408] in Kerberos_V5_Development
Re: [PATCH 2/2] pass the verto_ctx into preauth plugins
daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Nov 10 15:54:29 2011
Message-ID: <4EBC3A00.9070806@mit.edu>
Date: Thu, 10 Nov 2011 15:54:24 -0500
From: Greg Hudson <ghudson@mit.edu>
MIME-Version: 1.0
To: Sam Hartman <hartmans@mit.edu>
In-Reply-To: <tsl4nyb3gpc.fsf@mit.edu>
Cc: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On 11/10/2011 02:44 PM, Sam Hartman wrote:
> Can't the virto context be an incomplete type declared in the preauth
> plugin header?
Yes, although that creates knowledge of the underlying structure name.
(Which is struct _verto_ctx. Tom, should we ask for that to be changed
not to begin with an underscore?)
> Why does the kernel lib depend on the preauth plugin header anyway?
The relevant source files include <k5-int.h>, which includes
<krb5/preauth_plugin.h>. k5-int.h is a huge octopus bringing in all
sorts of headers declaring stuff which the kernel lib comes nowhere near
using, like port-sockets.h and com_err.h.
In http://k5wiki.kerberos.org/wiki/Projects/Kernel_subset I discuss
reorganizing k5-int.h to make it possible to get the declarations needed
by the kernel subset code without including everything, but I didn't do
that work.
Regardless, we're going to have this problem again if and when krb5.h
starts declaring async functionality. Again, we'll have the choice
between declaring verto_ctx ourselves and making verto.h a hard
dependency of krb5.h (and thus the kernel subset).
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
