[17325] in Kerberos_V5_Development
Make klog_vsyslog() public?
daemon@ATHENA.MIT.EDU (Linus Nordberg)
Fri Oct 28 17:45:34 2011
To: krbdev@mit.edu
From: Linus Nordberg <linus@nordu.net>
Date: Fri, 28 Oct 2011 17:45:11 -0400
Message-ID: <yszbot0hjtk.fsf@nordberg.se>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Complaints-To: usenet@dough.gmane.org
Errors-To: krbdev-bounces@mit.edu
--=-=-=
Hi,
I'd like to see klog_vsyslog() exported, enabling for logging wrappers.
I did the simplest thing in my tree for now, see below. There might be
more elaborate schemes for tracing (in a plugin) which would be more
powerful. I wouldn't object against that but there are issues, I hear.
Thanks,
Linus
--=-=-=
Content-Disposition: attachment
commit 8383841206a5680fceff7d2c69895caa78f0ffe2
Author: Linus Nordberg <linus@nordberg.se>
Date: Fri Oct 28 16:32:24 2011 -0400
Export klog_vsyslog as krb5_klog_vsyslog.
Modified src/include/adm_proto.h
diff --git a/src/include/adm_proto.h b/src/include/adm_proto.h
index c6d1425..eb68d3e 100644
--- a/src/include/adm_proto.h
+++ b/src/include/adm_proto.h
@@ -58,6 +58,7 @@ typedef struct ___krb5_key_salt_tuple krb5_key_salt_tuple;
/* logger.c */
krb5_error_code krb5_klog_init(krb5_context, char *, char *, krb5_boolean);
void krb5_klog_close(krb5_context);
+int krb5_klog_vsyslog(int, const char *, va_list);
int krb5_klog_syslog(int, const char *, ...)
#if !defined(__cplusplus) && (__GNUC__ > 2)
__attribute__((__format__(__printf__, 2, 3)))
Modified src/lib/kadm5/logger.c
diff --git a/src/lib/kadm5/logger.c b/src/lib/kadm5/logger.c
index 9b99635..9d3a224 100644
--- a/src/lib/kadm5/logger.c
+++ b/src/lib/kadm5/logger.c
@@ -799,15 +799,15 @@ severity2string(int severity)
* also performing the logging redirection as specified
* by krb5_klog_init().
*/
-static int
-klog_vsyslog(int priority, const char *format, va_list arglist)
+int
+krb5_klog_vsyslog(int priority, const char *format, va_list arglist)
#if !defined(__cplusplus) && (__GNUC__ > 2)
__attribute__((__format__(__printf__, 2, 0)))
#endif
;
-static int
-klog_vsyslog(int priority, const char *format, va_list arglist)
+int
+krb5_klog_vsyslog(int priority, const char *format, va_list arglist)
{
char outbuf[KRB5_KLOG_MAX_ERRMSG_SIZE];
int lindex;
@@ -930,7 +930,7 @@ krb5_klog_syslog(int priority, const char *format, ...)
va_list pvar;
va_start(pvar, format);
- retval = klog_vsyslog(priority, format, pvar);
+ retval = krb5_klog_vsyslog(priority, format, pvar);
va_end(pvar);
return(retval);
}
--=-=-=
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
--=-=-=--
