[17297] in Kerberos_V5_Development
Re: For review: GSS memory allocation patch
daemon@ATHENA.MIT.EDU (Greg Hudson)
Fri Oct 14 12:00:00 2011
Message-ID: <4E985C75.2060803@mit.edu>
Date: Fri, 14 Oct 2011 11:59:49 -0400
From: Greg Hudson <ghudson@mit.edu>
MIME-Version: 1.0
To: Kevin Wasserman <krwasserman@hotmail.com>
In-Reply-To: <SNT101-DS8F7517916AA01ACF2B572B5E10@phx.gbl>
Cc: Sam Hartman <hartmans@mit.edu>, "krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On 10/14/2011 09:27 AM, Kevin Wasserman wrote:
> "gssalloc memory management for gss_buffer_set."
> https://github.com/hartmans/kfw-updates/commit/5a4583e13eb5ac1597dff10abee0597bb714f4c6
I'm not fond of the kg_data_list_to_buffer_set_nocopy contract after
this change. What I'd like to see is:
* Remove the _nocopy suffix, since it's a lie on one platform (and also
the kg_ prefix, for unrelated reasons).
* The helper should destroy the data list on success or failure. The
current contract of "totally destroys on success, maybe partially
destroys on failure" makes it hard to verify correctness. (Before the
allocation change, the contract was "destroy on success, leave alone on
failure", which was reasonable.)
* Remove the extra layer of indirection for the data list.
A previously existing but related bug is that the caller should not fail
when the output attribute parameter is NULL.
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
