[17294] in Kerberos_V5_Development
Re: For review: GSS memory allocation patches
daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Oct 13 23:21:18 2011
Message-ID: <4E97AA9A.2070709@mit.edu>
Date: Thu, 13 Oct 2011 23:20:58 -0400
From: Greg Hudson <ghudson@mit.edu>
MIME-Version: 1.0
To: Sam Hartman <hartmans@mit.edu>
In-Reply-To: <tslty7cecsq.fsf@mit.edu>
Cc: "krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On 10/13/2011 06:39 PM, Sam Hartman wrote:
> At least when I looked at that patch gssapiP_generic.h included
> gssapi_alloc.h.
> So, that created a dependency.
That's in the next patch. The dependency update also wasn't done with
"make depend". Not really a big deal regardless.
> Should I commit Kevin's fixed versions of these?
Sure.
Kevin wrote:
> It makes the function definition in oid_ops.c match the prototype
> and thus avoids a compiler warning.
In this case, I think the const should be removed from the function
definition (some pointless consts are enshrined in RFC 2744 but this is
not one of them). Again, not a big deal.
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
