[17275] in Kerberos_V5_Development
Re: [PATCH 3/4] Use gssalloc_malloc()/gssalloc_free()
daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Oct 6 15:47:23 2011
From: Greg Hudson <ghudson@mit.edu>
To: Kevin Wasserman <krwasserman@hotmail.com>
In-Reply-To: <SNT101-DS1880D6EAC56FF34BC8B06DB5F90@phx.gbl>
Date: Thu, 06 Oct 2011 15:47:18 -0400
Message-ID: <1317930438.1548.31.camel@t410>
Mime-Version: 1.0
Cc: Sam Hartman <hartmans@painless-security.com>,
Kevin Wasserman <kevin.wasserman@painless-security.com>,
"krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On Thu, 2011-10-06 at 15:39 -0400, Kevin Wasserman wrote:
> I am concerned that you say you get a crash when logfile is set.
I didn't see a crash experimentally; it was implied from my misreading
of the code. I didn't realize that was a structure assignment.
> Again, though, I agree that this code is pretty badly structured
> and I'll clean it up along the lines you suggest.
Of course the code being badly structured predates your work; it's just
that the consequences aren't too severe until you introduce the
requirement that memory be freed according to how it was allocated.
Thanks for cleaning it up.
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
