[17257] in Kerberos_V5_Development
Re: [PATCH] Plugin Interface Change
daemon@ATHENA.MIT.EDU (Will Fiveash)
Wed Oct 5 19:54:52 2011
Date: Wed, 5 Oct 2011 18:54:38 -0500
From: Will Fiveash <will.fiveash@oracle.com>
To: Greg Hudson <ghudson@mit.edu>
Message-ID: <20111005235438.GC28537@sun.com>
Mail-Followup-To: Greg Hudson <ghudson@MIT.EDU>,
Nathaniel McCallum <npmccallum@redhat.com>,
"krbdev@mit.edu" <krbdev@MIT.EDU>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1317670156.2101.122.camel@t410>
Cc: "krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On Mon, Oct 03, 2011 at 03:29:16PM -0400, Greg Hudson wrote:
> The two most notable changes:
>
> * I adjusted the callback style so that in opaque form (as a void *),
> the callback argument is called "arg" and comes first in the callback
> argument list. Only in typed form in the invoker and callback is it
> called "state". A side benefit is that we don't need the name
> "newstate" when constructing state structures, since "state" won't
> conflict with the "arg" of the outer callback.
As an aside, having dealt with bugs related to the fact that void *
essentially disables C type checking wouldn't it be better to use a
incomplete struct pointer typedef?
Something like:
struct gss_ctx_id;
typedef struct gss_ctx_id *gss_ctx_id_t;
instead of:
typedef void *gss_ctx_id_t;
or am I off base?
--
Will Fiveash
Oracle
http://opensolaris.org/os/project/kerberos/
Sent using mutt, a sweet, text based e-mail app <http://www.mutt.org/>
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
