[17212] in Kerberos_V5_Development
Re: [PATCH] Make krb5-config suppress CFLAGS output and omit extra
daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Sep 26 11:17:31 2011
From: Greg Hudson <ghudson@mit.edu>
To: =?ISO-8859-1?Q?St=E9phane?= Gaudreault <stephane@archlinux.org>
In-Reply-To: <2536608.ODG4j3ejgY@assurancetourix>
Date: Mon, 26 Sep 2011 11:17:17 -0400
Message-ID: <1317050237.2101.53.camel@t410>
Mime-Version: 1.0
Cc: "krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="utf-8"
Errors-To: krbdev-bounces@mit.edu
Content-Transfer-Encoding: 8bit
On Mon, 2011-09-26 at 09:33 -0400, Stéphane Gaudreault wrote:> 1) Make krb5-config suppress CFLAGS output when called with --libs
I agree with this, after looking over the krb5-config version history.(Basically, when $(CFLAGS) was added to CC_LINK, a change was made tosubstitute $(CFLAGS) with $CFLAGS in krb5-config, but there's nocorresponding definition of CFLAGS earlier in the file as there are forother variables. Since I don't think we want to put things like -O2 inthe krb5-config --libs output, we should prune $(CFLAGS) altogether.
> 2) Omit extra libraries because their interfaces are not exposed to> applications by libkrb5.[...]> With patched krb5-config, setting do_deps to 1 indicates that the caller wants > the whole list.
This is more complicated. First, is do_deps an established convention?pkg-config uses the --static flag to decide whether to output dependencylibraries (on the theory that you need them for static linking but notshared linking).
Second, we already omit -lkrb5support from the displayed list to avoidcreating external dependencies on an internal library. To properlysupport do_deps or --static, we'd have to add -lkrb5support back in.
Third, the provided patch only omits external dependencies, not internalones (or com_err). An app using only GSSAPI functions should dependonly on libgssapi_krb5, not on libkrb5 and libk5crypto. However, it'slikely that apps have come to expect the current behavior--especially aswe don't appear to properly support things like "krb5-config --libsgssapi krb5". So, this problem may be intractable.
For the moment, I will commit the CFLAGS change and the removal ofexternal deps from --libs krb5, without any support for do_deps.
_______________________________________________krbdev mailing list krbdev@mit.eduhttps://mailman.mit.edu/mailman/listinfo/krbdev
