[17182] in Kerberos_V5_Development
Re: svn rev #25200: trunk/src/lib/gssapi/generic/
daemon@ATHENA.MIT.EDU (Greg Hudson)
Tue Sep 20 12:52:56 2011
From: Greg Hudson <ghudson@mit.edu>
To: Ken Raeburn <raeburn@mit.edu>
In-Reply-To: <9273EB94-51ED-463B-ABEA-93C8B8BCF173@mit.edu>
Date: Tue, 20 Sep 2011 12:52:52 -0400
Message-ID: <1316537572.718.265.camel@t410>
Mime-Version: 1.0
Cc: "krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On Tue, 2011-09-20 at 00:10 -0400, Ken Raeburn wrote:
> Is this a Windows compatibility thing? __func__ is the right
> direction for future c99 compatibility; __FUNCTION__ is non-standard
> AFAIK.
I didn't object to this change because (1) we use __FUNCTION__ all over
the code base already, and (2) it's in a debug block. But yes.
__FUNCTION__ is recognized by gcc but not Solaris cc (as of Sun C 5.9).
The right thing to do is probably to convert all uses of __FUNCTION__ in
to __func__ and "#define __func__ __FUNCTION__" in k5-platform.h if
_WIN32 is defined. If MSVC ever implements __func__, or if Cygwin/MinGW
is used to build the code base on Windows, then the define becomes
vestigial but harmless.
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
