[17158] in Kerberos_V5_Development
Re: [RFC][PATCH] krb5 => libverto main loop
daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Sep 12 12:39:16 2011
From: Greg Hudson <ghudson@mit.edu>
To: Nathaniel McCallum <nmccallu@redhat.com>
In-Reply-To: <743336146.1631631.1315601867611.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com>
Date: Mon, 12 Sep 2011 12:35:24 -0400
Message-ID: <1315845324.718.134.camel@t410>
Mime-Version: 1.0
Cc: "krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On Fri, 2011-09-09 at 16:57 -0400, Nathaniel McCallum wrote:
> Attached is a series of patches to deal with these issues.
In patch 2, loop_setup_signals() doesn't have correct error handling (it
deletes ctx, which is now an input parameter), and also has wonky
indentation for the goto label and following code.
Also, there is still a race where the master KDC receives a termination
signal just after forking the worker children and kills off the child
processes during the window where some or all of them are still trapping
signals in on_monitor_* (which causes them to be effectively ignored).
This race is unlikely to affect anyone (even the test suite), but we can
handle it in create_workers() by adding an "if (signal_received)
exit(0);" after calling loop_setup_signals().
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
