[16767] in Kerberos_V5_Development

home help back first fref pref prev next nref lref last post

Re: Pointer validation in the gss krb5 mech

daemon@ATHENA.MIT.EDU (Nico Williams)
Tue Apr 12 13:47:42 2011

MIME-Version: 1.0
In-Reply-To: <201104121725.p3CHPSID006893@outgoing.mit.edu>
Date: Tue, 12 Apr 2011 12:47:36 -0500
Message-ID: <BANLkTimzdp7nUp63VeU0m=UHg4Tn4MWb=g@mail.gmail.com>
From: Nico Williams <nico@cryptonector.com>
To: ghudson@mit.edu
Cc: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu

+1.

If we wanted any sort of validation I'd rather we intern handles and return
small integers (cast as pointers) instead of pointers.  Also, I'm not really
a fan of magic fields.  If garbage is passed in, better to segfault (or
assert) than to return an error that is likely to get ignored (thus masking
a bug).  Rip it out.

Nico
--
_______________________________________________
krbdev mailing list             krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev

home help back first fref pref prev next nref lref last post