[16263] in Kerberos_V5_Development
[PATCH] typos in pkinit_crypto_openssl.c
daemon@ATHENA.MIT.EDU (Olaf Flebbe)
Tue Sep 14 02:15:51 2010
Message-ID: <4C8F130B.5050003@science-computing.de>
Date: Tue, 14 Sep 2010 08:15:39 +0200
From: Olaf Flebbe <O.Flebbe@science-computing.de>
MIME-Version: 1.0
To: krbdev@mit.edu
Content-Type: multipart/mixed; boundary="------------000907060906020708010504"
Errors-To: krbdev-bounces@mit.edu
This is a multi-part message in MIME format.
--------------000907060906020708010504
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-15"; format="flowed"
Hi,
there are a couple of typos in pkinit_crypto_openssl.c which result in=20
compiler errors on HP-UX 11.11
gcc emits only warnings regarding different types in the conditional
operator (?:)
The typos result in casts to different types within the parts of a
conditional statement.
See Attachment for a patch for this issue.
Cheers,
Olaf
--=20
Vorstand/Board of Management:
Dr. Bernd Finkbeiner, Dr. Roland Niemeier,=20
Dr. Arno Steitz, Dr. Ingrid Zech
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Michel Lepert
Sitz/Registered Office: Tuebingen
Registergericht/Registration Court: Stuttgart
Registernummer/Commercial Register No.: HRB 382196=20
--------------000907060906020708010504
Content-Type: text/x-patch;
name="pkinit_crypto_openssl.c.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="pkinit_crypto_openssl.c.diff"
--- src/plugins/preauth/pkinit/pkinit_crypto_openssl.c.orig 2010-09-08 09:00:07.000000000 +0200
+++ src/plugins/preauth/pkinit/pkinit_crypto_openssl.c 2010-09-13 14:46:33.000000000 +0200
@@ -1230,7 +1230,7 @@
revoked = sk_X509_CRL_new_null();
for (i = 0; i < size; i++)
sk_X509_CRL_push(revoked, sk_X509_CRL_value(idctx->revoked, i));
- size = sk_X509_num(p7->d.sign->crl);
+ size = sk_X509_CRL_num(p7->d.sign->crl);
for (i = 0; i < size; i++)
sk_X509_CRL_push(revoked, sk_X509_CRL_value(p7->d.sign->crl, i));
}
@@ -4915,7 +4915,7 @@
continue;
}
if (flag != 0) {
- sk_X509_push(ca_crls, X509_CRL_dup(xi->crl));
+ sk_X509_CRL_push(ca_crls, X509_CRL_dup(xi->crl));
}
}
}
@@ -4945,7 +4945,7 @@
}
break;
case CATYPE_CRLS:
- if (sk_X509_num(ca_crls) == 0) {
+ if (sk_X509_CRL_num(ca_crls) == 0) {
pkiDebug("no crls in file, %s\n", filename);
if (id_cryptoctx->revoked == NULL)
sk_X509_CRL_free(ca_crls);
--------------000907060906020708010504
Content-Type: text/x-vcard; charset=utf-8;
name="O_Flebbe.vcf"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="O_Flebbe.vcf"
begin:vcard
fn:Dr. Olaf Flebbe
n:Flebbe;Olaf
org:science+computing -- a Bull Group Company;Software Solutions
adr;quoted-printable;dom:;;Hagellocher Weg 73;T=C3=BCbingen;;72070
email;internet:o.flebbe@science-computing.de
title:Chief Software Architect
tel;work:+49 7071 9457 254
tel;fax:+49 7071 9457 511
x-mozilla-html:FALSE
url:www.science-computing.de
version:2.1
end:vcard
--------------000907060906020708010504
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
--------------000907060906020708010504--
