[15942] in Kerberos_V5_Development
Re: design choices for a loadable module interface
daemon@ATHENA.MIT.EDU (Will Fiveash)
Tue Jun 29 20:06:36 2010
Date: Tue, 29 Jun 2010 19:06:44 -0500
From: Will Fiveash <will.fiveash@oracle.com>
To: Nicolas Williams <Nicolas.Williams@oracle.com>
Message-ID: <20100630000644.GD2232@sun.com>
Mail-Followup-To: Nicolas Williams <Nicolas.Williams@oracle.com>,
Russ Allbery <rra@stanford.edu>, krbdev@mit.edu
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20100629225647.GD11785@oracle.com>
Cc: Russ Allbery <rra@stanford.edu>, krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On Tue, Jun 29, 2010 at 05:56:47PM -0500, Nicolas Williams wrote:
> On Tue, Jun 29, 2010 at 03:19:25PM -0700, Russ Allbery wrote:
> >
> > Could you be more specific about exactly what functionality you see the
> > vtable approach as duplicating? I assume you mean something more than
> > just writing the struct definition of the vtable, since that's trivial.
>
> That. V-tables need to be written. And they make it harder to read the
> source, particularly since you're almost guaranteed to have different
> function names in every plugin, so now you have to search for
> assignments in cscope. And they're ugly (yes, an aesthetic argument).
Yes, I've found searching for plugin method definitions to be a total
pain when vtables are used and each plugin can arbitrarily name the
method/function assigned to the vtable. It would be much easier to
locate the various method definitions if the method/function names were
the same across all plugins supporting that method and that was enforced
by the plugin SPI framework.
--
Will Fiveash
Oracle
Note my new work e-mail address: will.fiveash@oracle.com
http://opensolaris.org/os/project/kerberos/
Sent using mutt, a sweet text based e-mail app: http://www.mutt.org/
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
