[15644] in Kerberos_V5_Development
Re: svn rev #23845: branches/krb5-1-8/src/lib/krb5/krb/
daemon@ATHENA.MIT.EDU (=?iso-8859-1?Q?Love_H=F6rnquist_=C)
Mon Mar 29 22:07:04 2010
X-KTH-mail-from: lha@kth.se
X-KTH-rcpt-to: krbdev@mit.edu
Mime-Version: 1.0 (Apple Message framework v1141)
From: =?iso-8859-1?Q?Love_H=F6rnquist_=C5strand?= <lha@kth.se>
In-Reply-To: <201003300151.o2U1p4fu019893@drugstore.mit.edu>
Date: Mon, 29 Mar 2010 19:06:55 -0700
Message-Id: <BEE3A1D4-0BF7-46C3-8984-3C550B0CB6A0@kth.se>
To: "krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
That would because its a continue needed flag.
Love
29 mar 2010 kl. 18:51 skrev tlyu@mit.edu:
> http://src.mit.edu/fisheye/changelog/krb5/?cs=23845
> Commit By: tlyu
> Log Message:
> ticket: 6693
> version_fixed: 1.8.1
> status: resolved
>
> pull up r23844 from trunk
>
> ------------------------------------------------------------------------
> r23844 | ghudson | 2010-03-29 18:08:21 -0400 (Mon, 29 Mar 2010) | 9 lines
>
> ticket: 6693
> subject: Fix backwards flag output in krb5_init_creds_step()
> tags: pullup
> target_version: 1.8.1
>
> krb5_init_creds_step() is taken from Heimdal, which sets *flags to 1
> for "continue" and 0 for "stop". Unfortunately, we got it backwards
> in 1.8; fix it for 1.8.1.
>
>
> Changed Files:
> U branches/krb5-1-8/src/lib/krb5/krb/get_in_tkt.c
> Modified: branches/krb5-1-8/src/lib/krb5/krb/get_in_tkt.c
> ===================================================================
> --- branches/krb5-1-8/src/lib/krb5/krb/get_in_tkt.c 2010-03-29 22:08:21 UTC (rev 23844)
> +++ branches/krb5-1-8/src/lib/krb5/krb/get_in_tkt.c 2010-03-30 01:51:04 UTC (rev 23845)
> @@ -1083,7 +1083,7 @@
> &flags);
> if (code == KRB5KRB_ERR_RESPONSE_TOO_BIG && !tcp_only)
> tcp_only = 1;
> - else if (code != 0 || (flags & KRB5_INIT_CREDS_STEP_FLAG_COMPLETE))
> + else if (code != 0 || (flags & 1) == 0)
> break;
>
> krb5_free_data_contents(context, &reply);
> @@ -2065,7 +2065,7 @@
> }
> }
>
> - *flags = (ctx->flags & KRB5_INIT_CREDS_STEP_FLAG_COMPLETE);
> + *flags = (ctx->flags & KRB5_INIT_CREDS_STEP_FLAG_COMPLETE) ? 0 : 1;
>
> return code;
> }
>
> _______________________________________________
> cvs-krb5 mailing list
> cvs-krb5@mit.edu
> https://mailman.mit.edu/mailman/listinfo/cvs-krb5
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
