[937] in Kerberos-V5-bugs
Install glitches...
daemon@ATHENA.MIT.EDU (Ted Lemon)
Thu Nov 3 16:46:42 1994
To: krb5-bugs@MIT.EDU
Date: Thu, 03 Nov 1994 13:46:16 -0800
From: Ted Lemon <mellon@ipd.wellsfargo.com>
There are a number of cases in the Kerberos V5 Beta 4.3 release where
man pages don't get installed, where header files get installed with
cp (which doesn't proactively set permissions) and where directories
get created with mkdir, which has the same problem. Also, the
install shell script doesn't exactly match the BSD install semantics
in that there's no default permission mask. The patches below
correct these problems.
_MelloN_
diff -rc2 src-orig/Makefile.in src/Makefile.in
*** src-orig/Makefile.in Mon Oct 3 20:32:58 1994
--- src/Makefile.in Wed Nov 2 16:16:22 1994
***************
*** 40,47 ****
install-mkdirs:
! @for i in $(INSTALLMKDIRS); do \
! if test -d $(DESTDIR)$$i; then :; else (set -x; mkdir $(DESTDIR)$$i); fi \
! done
!
# install::
# $(MAKE) $(MFLAGS) install.man
--- 40,52 ----
install-mkdirs:
! @for i in $(INSTALLMKDIRS); do \
! if test -d $(DESTDIR)$$i; then \
! :; \
! else \
! (set -x; mkdir $(DESTDIR)$$i; \
! chmod 755 $(DESTDIR)$$i); \
! fi \
! done
!
# install::
# $(MAKE) $(MFLAGS) install.man
diff -rc2 src-orig/appl/bsd/Makefile.in src/appl/bsd/Makefile.in
*** src-orig/appl/bsd/Makefile.in Thu Sep 29 20:47:06 1994
--- src/appl/bsd/Makefile.in Wed Nov 2 16:13:42 1994
***************
*** 31,34 ****
--- 31,35 ----
install::
$(INSTALL_PROGRAM) rsh $(DESTDIR)$(CLIENT_BINDIR)/rsh
+ $(INSTALL_DATA) rsh.M ${DESTDIR}$(CLIENT_MANDIR)/rsh.1
rcp: krcp.o kcmd.o forward.o $(SETENVOBJ) $(LIBOBJS) $(DEPKLIB)
***************
*** 37,40 ****
--- 38,42 ----
install::
$(INSTALL_PROGRAM) rcp $(DESTDIR)$(CLIENT_BINDIR)/rcp
+ $(INSTALL_DATA) rcp.M ${DESTDIR}$(CLIENT_MANDIR)/rcp.1
rlogin: krlogin.o kcmd.o forward.o $(SETENVOBJ) $(DEPKLIB)
***************
*** 43,46 ****
--- 45,49 ----
install::
$(INSTALL_PROGRAM) rlogin $(DESTDIR)$(CLIENT_BINDIR)/rlogin
+ $(INSTALL_DATA) rlogin.M ${DESTDIR}$(CLIENT_MANDIR)/rlogin.1
krshd: krshd.o kcmd.o logutil.o forward.o $(SETENVOBJ) $(DEPKLIB)
***************
*** 49,52 ****
--- 52,56 ----
install::
$(INSTALL_PROGRAM) krshd $(DESTDIR)$(SERVER_BINDIR)/krshd
+ $(INSTALL_DATA) krshd.M ${DESTDIR}$(SERVER_MANDIR)/krshd.8
krlogind: krlogind.o logutil.o kcmd.o forward.o $(SETENVOBJ) $(DEPKLIB)
***************
*** 55,58 ****
--- 59,63 ----
install::
$(INSTALL_PROGRAM) krlogind $(DESTDIR)$(SERVER_BINDIR)/krlogind
+ $(INSTALL_DATA) krlogind.M ${DESTDIR}$(SERVER_MANDIR)/krlogind.8
login.krb5: login.o logutil.o $(SETENVOBJ) $(LIBOBJS) $(DEPKLIB)
diff -rc2 src-orig/appl/telnet/telnet/Makefile.in src/appl/telnet/telnet/Makefile.in
*** src-orig/appl/telnet/telnet/Makefile.in Thu Sep 29 19:56:50 1994
--- src/appl/telnet/telnet/Makefile.in Wed Nov 2 16:13:42 1994
***************
*** 51,54 ****
--- 51,55 ----
install:
$(INSTALL_PROGRAM) telnet $(DESTDIR)$(CLIENT_BINDIR)/telnet
+ $(INSTALL_DATA) telnet.1 ${DESTDIR}$(CLIENT_MANDIR)/telnet.1
authenc.o: defines.h externs.h general.h ring.h types.h $(ARPA_TELNET)
diff -rc2 src-orig/appl/telnet/telnetd/Makefile.in src/appl/telnet/telnetd/Makefile.in
*** src-orig/appl/telnet/telnetd/Makefile.in Thu Sep 29 19:56:59 1994
--- src/appl/telnet/telnetd/Makefile.in Wed Nov 2 16:13:42 1994
***************
*** 60,63 ****
--- 60,64 ----
install::
$(INSTALL_PROGRAM) telnetd $(DESTDIR)$(SERVER_BINDIR)/telnetd
+ $(INSTALL_DATA) telnetd.8 ${DESTDIR}$(SERVER_MANDIR)/telnetd.8
authenc.o: telnetd.h
diff -rc2 src-orig/include/kerberosIV/Makefile.in src/include/kerberosIV/Makefile.in
*** src-orig/include/kerberosIV/Makefile.in Mon Oct 3 18:22:33 1994
--- src/include/kerberosIV/Makefile.in Wed Nov 2 16:13:42 1994
***************
*** 17,20 ****
install:: $(KRB4_HEADERS)
@set -x; for f in $(KRB4_HEADERS) ; \
! do cp $(srcdir)/$$f $(DESTDIR)$(KRB5_INCDIR)/kerberosIV/$$f ; \
done
--- 17,20 ----
install:: $(KRB4_HEADERS)
@set -x; for f in $(KRB4_HEADERS) ; \
! do $(INSTALL_DATA) $$f $(KRB5_INCDIR)/kerberosIV/$$f ; \
done
diff -rc2 src-orig/include/kerberosIV/configure.in src/include/kerberosIV/configure.in
*** src-orig/include/kerberosIV/configure.in Fri Jun 17 00:06:00 1994
--- src/include/kerberosIV/configure.in Wed Nov 2 16:13:43 1994
***************
*** 3,5 ****
--- 3,6 ----
CONFIG_RULES
WITH_KRB5ROOT
+ AC_PROG_INSTALL
AC_OUTPUT(Makefile,[EXTRA_RULES])
diff -rc2 src-orig/include/krb5/Makefile.in src/include/krb5/Makefile.in
*** src-orig/include/krb5/Makefile.in Mon Oct 3 18:22:35 1994
--- src/include/krb5/Makefile.in Wed Nov 2 16:19:13 1994
***************
*** 8,11 ****
--- 8,13 ----
narrow.h proto.h rcache.h rsa-md4.h safepriv.h \
sysincl.h widen.h wordsize.h
+ OTHER_HEADERS = adm_err.h asn1_err.h isode_err.h kdb5_err.h krb5_err.h \
+ autoconf.h config.h osconf.h
all:: autoconf.h osconf.h config.h
***************
*** 29,37 ****
KRB5_INCDIR = $(KRB5ROOT)/include
! install:: $(KRB5_HEADERS) config.h osconf.h autoconf.h
! @set -x; for f in $(KRB5_HEADERS) ; \
do cp $(srcdir)/$$f $(DESTDIR)$(KRB5_INCDIR)/krb5/$$f ; \
done
- cp config.h osconf.h $(DESTDIR)$(KRB5_INCDIR)/krb5/$$f
PROCESS_REPLACE = -e "s+@KRB5ROOT+$(KRB5ROOT)+" \
--- 31,38 ----
KRB5_INCDIR = $(KRB5ROOT)/include
! install:: $(KRB5_HEADERS) config.h osconf.h autoconf.h $(OTHER_HEADERS)
! @set -x; for f in $(KRB5_HEADERS) $(OTHER_HEADERS); \
do cp $(srcdir)/$$f $(DESTDIR)$(KRB5_INCDIR)/krb5/$$f ; \
done
PROCESS_REPLACE = -e "s+@KRB5ROOT+$(KRB5ROOT)+" \
diff -rc2 src-orig/include/krb5/configure.in src/include/krb5/configure.in
*** src-orig/include/krb5/configure.in Tue Aug 16 19:26:00 1994
--- src/include/krb5/configure.in Wed Nov 2 16:13:43 1994
***************
*** 5,8 ****
--- 5,9 ----
AC_CONFIG_HEADER(autoconf.h)
AC_PROG_LEX
+ AC_PROG_INSTALL
HAVE_YYLINENO
AC_FUNC_CHECK(strdup,AC_DEFINE(HAS_STRDUP))
diff -rc2 src-orig/util/autoconf/install.sh src/util/autoconf/install.sh
*** src-orig/util/autoconf/install.sh Thu Jun 30 16:09:40 1994
--- src/util/autoconf/install.sh Wed Nov 2 16:13:43 1994
***************
*** 29,33 ****
instcmd="$mvprog"
! chmodcmd=""
chowncmd=""
chgrpcmd=""
--- 29,33 ----
instcmd="$mvprog"
! chmodcmd="$chmodprog 0755"
chowncmd=""
chgrpcmd=""
--
Ted Lemon Wells Fargo Bank, Information Protection Division
mellon@ipd.wellsfargo.com +1 415 477 5045
