[932] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

Patches to appl/mailquery and appl/popper

daemon@ATHENA.MIT.EDU (Richard Basch)
Wed Nov 2 20:02:42 1994

Date: Wed, 2 Nov 1994 20:02:33 -0500
To: krb5-bugs@MIT.EDU
From: "Richard Basch" <basch@MIT.EDU>


===================================================================
NULL should not be used as a character assignment value.  Use '\0'
instead.
===================================================================

RCS file: /mit/krb5/.cvsroot/src/appl/mailquery/poplib.c,v
retrieving revision 1.5
diff -c -r1.5 poplib.c
*** poplib.c	1994/08/18 21:05:28	1.5
--- poplib.c	1994/11/02 23:40:17
***************
*** 376,384 ****
  	return (DONE);
      }
  
!     *p = NULL;
!     if (*--p == '\n') *p = NULL;
!     if (*--p == '\r') *p = NULL;
      return(OK);
  }
  
--- 376,384 ----
  	return (DONE);
      }
  
!     *p = '\0';
!     if (*--p == '\n') *p = '\0';
!     if (*--p == '\r') *p = '\0';
      return(OK);
  }
  
***************
*** 389,395 ****
  {
      if (getline(buf, n, f) != OK) return (NOTOK);
      if (*buf == '.') {
! 	if (*(buf+1) == NULL) {
  	    return (DONE);
  	} else {
  	    strcpy(buf, buf+1);
--- 389,395 ----
  {
      if (getline(buf, n, f) != OK) return (NOTOK);
      if (*buf == '.') {
! 	if (*(buf+1) == '\0') {
  	    return (DONE);
  	} else {
  	    strcpy(buf, buf+1);

===================================================================
MAXHOSTNAMELEN might be declared elsewhere, so only declare its value if
it isn't already declared elsewhere.
===================================================================

RCS file: /mit/krb5/.cvsroot/src/appl/popper/popper.h,v
retrieving revision 1.3
diff -c -r1.3 popper.h
*** popper.h	1994/08/18 21:06:15	1.3
--- popper.h	1994/11/02 22:58:16
***************
*** 24,30 ****
--- 24,32 ----
  #define FALSE           0
  #define NEWLINE         '\n'
  
+ #ifndef MAXHOSTNAMELEN
  #define MAXHOSTNAMELEN  256
+ #endif
  #define MAXUSERNAMELEN  65
  #define MAXDROPLEN      64
  #define MAXLINELEN      1024

home help back first fref pref prev next nref lref last post