[883] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

kadmin/v4server/kadm_ser_wrap.c

daemon@ATHENA.MIT.EDU (epeisach@MIT.EDU)
Wed Oct 19 21:16:49 1994

From: epeisach@MIT.EDU
Date: Wed, 19 Oct 1994 21:16:42 -0400
To: krb5-bugs@MIT.EDU


The recent change to the file has the following:

    if (!valid_etype(kdc_etype)) {
	com_err(argv[0], KRB5_PROG_ETYPE_NOSUPP,
		"while setting up etype %d", kdc_etype);
	exit(1);
    }

But argv[0] is not defined as far as this file is concerned... 

Also, the master block is stored in a structure....

May I suggest the following:

===================================================================
RCS file: /mit/krb5/.cvsroot/src/kadmin/v4server/kadm_ser_wrap.c,v
retrieving revision 1.9
diff -c -r1.9 kadm_ser_wrap.c
*** 1.9	1994/10/19 22:54:48
--- kadm_ser_wrap.c	1994/10/20 01:14:25
***************
*** 32,37 ****
--- 32,39 ----
  
  Kadm_Server server_parm;
  
+ extern char *progname;
+ 
  /* 
  kadm_ser_init
  set up the server_parm structure
***************
*** 78,88 ****
      server_parm.master_keyblock.keytype = KEYTYPE_DES;
      
      if (!valid_etype(kdc_etype)) {
! 	com_err(argv[0], KRB5_PROG_ETYPE_NOSUPP,
  		"while setting up etype %d", kdc_etype);
  	exit(1);
      }
!     krb5_use_cstype(&master_encblock, kdc_etype);
      
      retval = krb5_db_setup_mkey_name(mkey_name, realm, (char **) 0,
  				     &server_parm.master_princ);
--- 80,90 ----
      server_parm.master_keyblock.keytype = KEYTYPE_DES;
      
      if (!valid_etype(kdc_etype)) {
! 	com_err(progname, KRB5_PROG_ETYPE_NOSUPP,
  		"while setting up etype %d", kdc_etype);
  	exit(1);
      }
!     krb5_use_cstype(&server_parm.master_encblock, kdc_etype);
      
      retval = krb5_db_setup_mkey_name(mkey_name, realm, (char **) 0,
  				     &server_parm.master_princ);

home help back first fref pref prev next nref lref last post