[852] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

crypto cleanup and check

daemon@ATHENA.MIT.EDU (epeisach@MIT.EDU)
Thu Oct 13 18:55:38 1994

From: epeisach@MIT.EDU
Date: Thu, 13 Oct 1994 18:55:34 -0400
To: krb5-bugs@MIT.EDU


a) make clean in crypto does not remove the library that is built
	(I may have reported this before)	
b) md5/t_mddriver.c - MD*update expect the second argument to be an unsigned
char *. I cheated by casting in the relevant calls. I could hav changed
the prototype for MDstring, but then I would need to cast the call with
argv in the beginning. Also changing the md_test structure entry for
string would affect the initialization on the structs and you would need
casting there... I think I took the lesser of the evils..
(this change was not really required, but it took care of a warning)

	Ezra

===================================================================
RCS file: /mit/krb5/.cvsroot/src/lib/crypto/Makefile.in,v
retrieving revision 1.10
diff -c -r1.10 Makefile.in
*** 1.10	1994/10/04 01:14:53
--- Makefile.in	1994/10/04 11:29:42
***************
*** 20,22 ****
--- 20,25 ----
  install:: libcrypto.a
  	$(INSTALL_DATA) libcrypto.a $(DESTDIR)$(KRB5_LIBDIR)/libcrypto.a
  	$(RANLIB) $(DESTDIR)$(KRB5_LIBDIR)/libcrypto.a
+ 
+ clean::
+ 	$(RM) libcrypto.a
===================================================================
RCS file: /mit/krb5/.cvsroot/src/lib/crypto/md5/t_mddriver.c,v
retrieving revision 5.1
diff -c -r5.1 t_mddriver.c
*** 5.1	1994/10/13 21:53:46
--- t_mddriver.c	1994/10/13 22:48:38
***************
*** 170,176 ****
    unsigned int len = strlen (string);
  
    MDInit (&context);
!   MDUpdate (&context, string, len);
    MDFinal (&context);
  
    printf ("MD%d (\"%s\") = ", MD, string);
--- 170,176 ----
    unsigned int len = strlen (string);
  
    MDInit (&context);
!   MDUpdate (&context, (unsigned char*) string, len);
    MDFinal (&context);
  
    printf ("MD%d (\"%s\") = ", MD, string);
***************
*** 230,236 ****
  	unsigned int len = strlen (entry->string);
  
  	MDInit (&context);
! 	MDUpdate (&context, entry->string, len);
  	MDFinal (&context);
  
  	printf ("MD%d (\"%s\") = ", MD, entry->string);
--- 230,236 ----
  	unsigned int len = strlen (entry->string);
  
  	MDInit (&context);
! 	MDUpdate (&context, (unsigned char *) entry->string, len);
  	MDFinal (&context);
  
  	printf ("MD%d (\"%s\") = ", MD, entry->string);

home help back first fref pref prev next nref lref last post