[776] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

comparison typos in krb5_encode.c

daemon@ATHENA.MIT.EDU (Ward_Travis@transarc.com)
Mon Sep 26 15:38:02 1994

Date: Mon, 26 Sep 1994 15:36:25 -0400 (EDT)
From: Ward_Travis@transarc.com
To: krb5-bugs@MIT.EDU

In KRB5B4, I found the following lines in routine
encode_krb5_enc_kdc_rep_part(), file krb5_encode.c . In the (currently
uncompiled) 'else' clause of the #ifndef, it appears == was meant, but =
was used. No?



krb5_error_code encode_krb5_enc_kdc_rep_part(DECLARG(const krb5_enc_kdc_rep_part *, rep),
                                             DECLARG(krb5_data **, code))
     OLDDECLARG(const krb5_enc_kdc_rep_part *, rep)
     OLDDECLARG(krb5_data **, code)
{
  asn1_error_code retval;
  asn1buf *buf=NULL;
  int length, sum=0;

  if(rep == NULL) return ASN1_MISSING_FIELD;

  retval = asn1buf_create(&buf);
  if(retval) return retval;

  retval = asn1_encode_enc_kdc_rep_part(buf,rep,&length);
  if(retval) return retval;
  sum += length;

#ifndef ENCKRB5KDCREPPART_HAS_MSGTYPE
  krb5_apptag(26);
#else
  if(rep->msg_type = KRB5_AS_REP){ krb5_apptag(ASN1_KRB_AS_REP); }
  else if(rep->msg_type = KRB5_TGS_REP){ krb5_apptag(ASN1_KRB_TGS_REP); }
  else return KRB5_BADMSGTYPE;
#endif
  krb5_cleanup();
}


--
Ward C. Travis	     Pittsburgh PA USA	"The fact is the sweetest dream that
travis@transarc.com	(412) 338 4388	       labor knows."  - R. Frost

home help back first fref pref prev next nref lref last post