[768] in Kerberos-V5-bugs
Re: mit-kerberos5/2561: kprop fails because of fix to rd_safe
daemon@ATHENA.MIT.EDU (Barry Jaspan)
Thu Sep 22 12:18:24 1994
Date: Thu, 22 Sep 94 12:19:58 EDT
From: "Barry Jaspan" <bjaspan@cam.ov.com>
To: krb5-bugs@MIT.EDU
Cc: ov-security-gnats@cam.ov.com
In-Reply-To: Barry Jaspan's message of Wed, 21 Sep 94 18:16:41 EDT
<9409212216.AA17265@suan-la-chow-show.cam.ov.com>
There is a bug in kprop that did not manifest itself until the recent
NOTIME fix to krb5_rd_safe. kprop is passing the wrong value as the
sender address to krb5_mk_safe and, with the NOTIME fix, krb5_rd_safe
rejects the packet as having an invalid network address.
The following patch fixes the problem. Note that this patch depends
on our previous kprop patches.
Barry Jaspan, bjaspan@cam.ov.com
OpenVision Technologies, Inc.
*** 1.7 1994/09/01 17:59:22
--- kprop.c 1994/09/22 16:19:14
***************
*** 322,331 ****
sizeof(sin.sin_addr));
socket_length = sizeof(sin);
! if (getpeername(s, (struct sockaddr *)&sin, &socket_length) < 0) {
retval = errno;
close(s);
! (void) sprintf(Errmsg, "in call to getpeername");
return(retval);
}
sender_addr.addrtype = ADDRTYPE_INET;
--- 322,331 ----
sizeof(sin.sin_addr));
socket_length = sizeof(sin);
! if (getsockname(s, (struct sockaddr *)&sin, &socket_length) < 0) {
retval = errno;
close(s);
! (void) sprintf(Errmsg, "in call to getsockname");
return(retval);
}
sender_addr.addrtype = ADDRTYPE_INET;