[708] in Kerberos-V5-bugs
V4 server should use krb5_timeofday(), not time()
daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Mon Sep 5 10:51:49 1994
Date: Mon, 5 Sep 1994 10:53:03 -0400
From: "Jonathan I. Kamens" <jik@cam.ov.com>
To: krb5-bugs@MIT.EDU
--- /afs/gza.com/development/krb5.beta4/src/kadmin/v4server/kadm_funcs.c Fri Jun 24 02:19:06 1994
+++ kadm_funcs.c Mon Sep 5 10:51:54 1994
@@ -222,7 +222,10 @@
failadd(KADM_INUSE);
} else {
newentry.kvno = ++data_i.key_version;
- newentry.mod_date = time(0);
+ if (retval = krb5_timeofday(&newentry.mod_date)) {
+ krb5_db_free_principal(&newentry, 1);
+ failadd(retval);
+ }
if (newentry.mod_name)
krb5_free_principal(newentry.mod_name);
newentry.mod_name = NULL; /* in case the following breaks */
@@ -405,7 +408,10 @@
}
newentry.key = encpw;
}
- newentry.mod_date = time(0);
+ if (retval = krb5_timeofday(&newentry.mod_date)) {
+ krb5_db_free_principal(&newentry, 1);
+ failmod(retval);
+ }
retval = krb5_425_conv_principal(rname, rinstance, rrealm,
&newentry.mod_name);
if (retval) {
@@ -503,7 +509,10 @@
odata.key = encpw;
odata.kvno++;
odata.mkvno = server_parm.mkvno;
- odata.mod_date = time(0);
+ if (retval = krb5_timeofday(&odata.mod_date)) {
+ krb5_db_free_principal(&odata, 1);
+ failchange(retval);
+ }
krb5_425_conv_principal(rname, rinstance,
server_parm.krbrlm, &odata.mod_name);
if (retval) {
@@ -835,7 +844,10 @@
krb5_db_free_principal(&odata, 1);
failsrvtab(retval);
}
- odata.mod_date = time(0);
+ if (retval = krb5_timeofday(&odata.mod_date)) {
+ krb5_db_free_principal(&odata, 1);
+ failsrvtab(retval);
+ }
retval = krb5_425_conv_principal(rname, rinstance,
server_parm.krbrlm, &odata.mod_name);
if (retval) {
