[705] in Kerberos-V5-bugs
krb5_rd_req_simple duplicates code it doesn't have to
daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Sun Sep 4 22:08:24 1994
Date: Sun, 4 Sep 1994 22:09:34 -0400
From: "Jonathan I. Kamens" <jik@cam.ov.com>
To: krb5-bugs@MIT.EDU
krb5_rd_req_simple should use krb5_rd_req, not krb5_rd_req_decoded, so
that it doesn't have to duplicate most of the code in krb5_rd_req.
--- /afs/gza.com/development/krb5.beta4/src/lib/krb5/krb/rd_req_sim.c Wed Jun 29 01:35:35 1994
+++ rd_req_sim.c Sun Sep 4 22:07:00 1994
@@ -61,24 +61,8 @@
krb5_tkt_authent **authdat;
{
krb5_error_code retval;
- krb5_ap_req *request;
krb5_rcache rcache = 0;
- if (!krb5_is_ap_req(inbuf))
- return KRB5KRB_AP_ERR_MSG_TYPE;
- if (retval = decode_krb5_ap_req(inbuf, &request)) {
- switch (retval) {
-#ifdef KRB5_USE_ISDOE
- case ISODE_50_LOCAL_ERR_BADMSGTYPE:
-#else
- case KRB5_BADMSGTYPE:
-#endif
- return KRB5KRB_AP_ERR_BADVERSION;
- default:
- return(retval);
- }
- }
-
if (server) {
retval = krb5_get_server_rcache(krb5_princ_component(server, 0),
&rcache);
@@ -86,12 +70,11 @@
goto cleanup;
}
- retval = krb5_rd_req_decoded(request, server, sender_addr, 0, 0, 0,
- rcache, authdat);
+ retval = krb5_rd_req(inbuf, server, sender_addr, 0, 0, 0,
+ rcache, authdat);
cleanup:
if (rcache)
krb5_rc_close(rcache);
- krb5_free_ap_req(request);
return retval;
}
