[690] in Kerberos-V5-bugs
get_in_tkt doesn't return error if krb5_os_localaddr fails
daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Thu Sep 1 13:31:50 1994
Date: Thu, 1 Sep 1994 13:33:00 -0400
From: "Jonathan I. Kamens" <jik@cam.ov.com>
To: krb5-bugs@MIT.EDU
get_in_tkt calls krb5_os_localaddr if the addrs parameter passed into
it is null. Unfortunately, it doesn't check the return value and
return an error if it returns an error.
The patch below (against beta 4) fixes that.
Jonathan Kamens | OpenVision Technologies, Inc. | jik@cam.ov.com
--- /afs/gza.com/development/krb5.beta4/src/lib/krb5/krb/get_in_tkt.c Thu Jun 2 12:40:02 1994
+++ get_in_tkt.c Thu Sep 1 13:31:27 1994
@@ -122,11 +122,11 @@
*ret_as_reply = 0;
request.msg_type = KRB5_AS_REQ;
- if (!addrs)
- krb5_os_localaddr(&request.addresses);
- else
+ if (addrs)
request.addresses = (krb5_address **) addrs;
-
+ else if (retval = krb5_os_localaddr(&request.addresses))
+ return retval;
+
reply.data = 0;
if (pre_auth_type == KRB5_PADATA_NONE) {
