[684] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

kpropd "-s srvtab" option is broken

daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Tue Aug 30 16:22:03 1994

Date: Tue, 30 Aug 1994 16:23:23 -0400
From: "Jonathan I. Kamens" <jik@cam.ov.com>
To: krb5-bugs@MIT.EDU

The "-s srvtab" option to kpropd doesn't work.  The patch below fixes
it by making the following changes:

 Deleted the KPROP_SRVTAB constant from kprop.h, because it isn't
 needed.  Deleted the srvtab variable from kpropd.c and replaced
 references to it with references to the already existing kerb_keytab
 variable.  Changes "-s srvtab" to "-k keytab" both in the usage
 message and the command-line parsing code.

I haven't updated the man page.

This patch is against beta 2, so it might have a little trouble
applying to the beta 4 sources, but the changes are pretty
straightforward.

Jonathan Kamens  |  OpenVision Technologies, Inc.  |   jik@cam.ov.com

*** kprop.h	1993/11/18 19:58:09	1.1
--- kprop.h	1994/08/30 20:18:59
***************
*** 26,32 ****
   */
  
  #define KPROP_SERVICE_NAME "host"
- #define KPROP_SRVTAB "/etc/srvtab"
  #define TGT_SERVICE_NAME "krbtgt"
  #define KPROP_SERVICE "krb5_prop"
  #define KPROP_DEFAULT_FILE "/krb5/slave_datatrans"
--- 26,31 ----
*** kpropd.c	1994/05/30 19:29:29	1.5
--- kpropd.c	1994/08/30 20:19:37
***************
*** 77,83 ****
  
  char	*progname;
  int     debug = 0;
- char	*srvtab = 0;
  int	standalone;
  
  krb5_principal	server;		/* This is our server principal name */
--- 77,82 ----
***************
*** 112,118 ****
  static void usage()
  {
  	fprintf(stderr,
! 		"\nUsage: %s [-r realm] [-s srvtab] [-dS] [-f slave_file]\n",
  		progname);
  	fprintf(stderr, "\t[-F kerberos_db_file ] [-p kdb5_edit_pathname]\n\n",
  		progname);
--- 111,117 ----
  static void usage()
  {
  	fprintf(stderr,
! 		"\nUsage: %s [-r realm] [-k keytab] [-dS] [-f slave_file]\n",
  		progname);
  	fprintf(stderr, "\t[-F kerberos_db_file ] [-p kdb5_edit_pathname]\n\n",
  		progname);
***************
*** 406,417 ****
  						usage();
  					word = 0;
  					break;
! 				case 's':
  					if (*word)
! 						srvtab = word;
  					else
! 						srvtab = *argv++;
! 					if (!srvtab)
  						usage();
  					word = 0;
  					break;
--- 405,416 ----
  						usage();
  					word = 0;
  					break;
! 				case 'k':
  					if (*word)
! 						kerb_keytab = word;
  					else
! 						kerb_keytab = *argv++;
! 					if (!kerb_keytab)
  						usage();
  					word = 0;
  					break;

home help back first fref pref prev next nref lref last post