[487] in Kerberos-V5-bugs
Re: krb5_get_in_tkt_with_skey
daemon@ATHENA.MIT.EDU (Theodore Ts'o)
Wed Jun 1 15:27:48 1994
Date: Wed, 1 Jun 94 15:27:29 EDT
From: tytso@MIT.EDU (Theodore Ts'o)
To: georgesr@wrq.com
Cc: krb5-bugs@MIT.EDU, georgesr@elmer.wrq.com
In-Reply-To: georges rahbani's message of Fri, 27 May 1994 15:27:42 -0700,
<9405272227.AA15568@MIT.EDU>
Date: Fri, 27 May 1994 15:27:42 -0700
From: georgesr@wrq.com (georges rahbani)
The function krb5_get_in_tkt_with_skey calls the function
get_in_tkt and passes the address of the function skey_keyproc as an
argument. All is good, but skey_keyproc after it calls copy_keyblock
it checks for return value. If there was an error it calls krb5_xfree
(realkey);. Now, ifthere was an error, realkey will not be pointing
to anything allocated. This free call may be ok on some systems, but
I guess on others it may cause problems (I think). Is this true?
Quite correct. The krb5_xfree(realkey) should be deleted.
Thanks again!
- Ted
