[482] in Kerberos-V5-bugs
new krb5_get_in_TKT
daemon@ATHENA.MIT.EDU (georges rahbani)
Wed May 25 17:57:04 1994
Date: Wed, 25 May 1994 14:56:50 -0700
To: krb5-bugs@MIT.EDU
From: georgesr@wrq.com (georges rahbani)
Cc: georgesr@elmer.wrq.com
Hi Ted,
Thank you for sending the new implementation of krb5_get_in_tkt. It is
much better than the one before it. Hoever there are some places where I am
not sure what is going on.
* request.addresses: This field is either set to the addrs passed as a
parameter in which case everything is OK. Or krb5_os_localaddr allocates. In
this case, I seem to have missed where to free this address array. And if we
do (?) We should make sure not to free the parameter addrs memory.
* The cleanup stuff seems ok but in reverse order. If we get any errors
after we start to fill the creds struct, we jump to cred_cleanup. This is
fine, but in this case we don't free the other stuff that cleanup frees and
we don't return any error codes.
What I have done is add a jump to cleanup and that (I think) should solve
the problem).
Thank you for your patience with me.
Georges Rahbani
Walker, Richer & Quinn, Inc.
georgesr@wrq.com
