[4135] in Kerberos-V5-bugs
Re: [krbdev.mit.edu #1432] patch to compile with cygwin
daemon@ATHENA.MIT.EDU (Ken Raeburn)
Wed Apr 23 21:11:16 2003
To: rt-comment@krbdev.MIT.EDU
From: Ken Raeburn <raeburn@MIT.EDU>
Date: Wed, 23 Apr 2003 21:10:59 -0400
In-Reply-To: <rt-1432-5794.0.47261347509405@krbdev.mit.edu> ("\"\"Christopher
B. Liebman\" via RT\""'s message of "Sun, 20 Apr 2003 02:18:48 -0400
(EDT)")
Message-ID: <tx1of2wsnrw.fsf@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
cc: krb5-prs@MIT.EDU
Errors-To: krb5-bugs-bounces@mit.edu
"\"\"Christopher B. Liebman\" via RT\"" <rt-comment@krbdev.mit.edu> writes:
> There are two issues that this patch fixes:
>
> 1) Cygwin implements error as a function that returns an int. There are
> locations in krb5 that declare errno as "extern int errno" the patch
> includes errno.h instead. Maybe a better fix is to have configure look to
> see if errno.h exists and include it?
Declaring errno explicitly is just wrong, because any ANSI C platform
is allowed to do this. (At worst, we could declare it *if* the system
errno.h doesn't; I don't think anything more recent than SunOS 4 fails
to declare it.) We probably don't lose on UNIX platforms just because
the macro versions -- when there are any -- are syntactically
compatible with use in declarations as well as expression, which is
not required by ANSI C.
We do still have many such declarations in the 1.3 branch.
While we're at it, some of the krb4 code declares errmsg() right along
with errno, but I don't think it exists or is used.
> 2) Cygwin has the same issues as Windows/DOS with renaming a file while it's
> still open. This patch uses almost exactly the same code to fix this issue
> manifesting in the replay cache code.
Makes sense....
Ken
_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
http://mailman.mit.edu/mailman/listinfo/krb5-bugs
