[377] in Kerberos-V5-bugs
trivial memory leak in recvauth
daemon@ATHENA.MIT.EDU (Jim Miller)
Fri Oct 15 20:03:26 1993
From: jim@bilbo.suite.com (Jim Miller)
Date: Fri, 15 Oct 93 18:49:39 -0500
To: krb5-bugs@MIT.EDU
Reply-To: Jim_Miller@suite.com
This is for Kerberos 5, pre-beta 3...
The code...
/*
* At this point, we've won. We just need to copy whatever
* parts of the authdat structure which the user wants, clean
* up, and exit.
*/
if (client)
if (retval =
krb5_copy_principal(authdat->ticket->enc_part2->client,
client))
return(retval); <--** haven't freed "authdat"
If "krb5_copy_principal" returns will an error, the "authdat" structure never
gets freed. Not a big show stopper.
Suggested fix:
if (client)
if (retval =
krb5_copy_principal(authdat->ticket->enc_part2->client,
! client)) {
+ krb5_free_tkt_authent(authdat);
return(retval);
+ }
Jim_Miller@suite.com