[374] in Kerberos-V5-bugs
Re: oops, try this sendauth fix instead
daemon@ATHENA.MIT.EDU (Theodore Ts'o)
Fri Oct 15 14:43:39 1993
Date: Fri, 15 Oct 93 14:42:20 EDT
From: tytso@MIT.EDU (Theodore Ts'o)
To: Jim_Miller@suite.com
Cc: krb5-bugs@MIT.EDU
In-Reply-To: Jim Miller's message of Thu, 14 Oct 93 19:15:01 -0500,
From: jim@bilbo.suite.com (Jim Miller)
Date: Thu, 14 Oct 93 19:15:01 -0500
My previous sendauth bug fix was not much of an improvement. How
about this one...
if (!credsp->ticket.length) {
if (!ccache) { <--** better have a ccache!
krb5_free_cred_contents(&creds);
return(KRB5_NOCREDS_SUPPLIED);
}
if (retval = krb5_get_credentials(connector,
kdc_options,
ccache,
credsp)) { <--** use credsp
krb5_free_cred_contents(&creds);
return(retval);
}
}
You don't need the first krb5_free_cred_contents(&creds), since if
credsp points to creds at this point, ccache must be set.
At the risk of asking a silly question, where did that first argument to
krb5_get_credentials come from? I don't recognize where "connector"
came from....
Thanks for going through the kerberos source with a fine tooth comb; I
really appreciate the auditing that you're doing!
- Ted
