[368] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

trivial memory leak in sendauth

daemon@ATHENA.MIT.EDU (Jim Miller)
Thu Oct 14 18:26:28 1993

From: jim@bilbo.suite.com (Jim Miller)
Date: Thu, 14 Oct 93 17:11:13 -0500
To: krb5-bugs@MIT.EDU
Reply-To: Jim_Miller@suite.com


As you might expect by now, this bug report is for Kerberos 5, pre-beta 3...


in lib/krb/sendauth.c...


	if (inbuf.length) {
		if (error) {
			if (retval = krb5_rd_error(&inbuf, error)) {
				xfree(inbuf.data);
				return(retval);
			}
		}
		xfree(inbuf.data);
		krb5_free_cred_contents(&creds);
		memset((char *)&authent, 0, sizeof(authent));
		return(KRB5_SENDAUTH_REJECTED);
	}


Tracing through the "if (inbuf.legnth) if (error)" path you see that "creds"  
doesn't get freed if "krb5_rd_error" returns a fail status.  Minor, but  
still...


Jim_Miller@suite.com


home help back first fref pref prev next nref lref last post