[3530] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

Re: [krbdev.mit.edu #1216]

daemon@ATHENA.MIT.EDU (nalin@redhat.com via RT)
Fri Oct 11 15:18:42 2002

Mail-Followup-To: rt@krbdev.mit.edu
Message-Id: <rt-1216-3182.17.1073521438935@krbdev.mit.edu>
In-Reply-To: <rt-1216@krbdev.mit.edu>
From: "nalin@redhat.com via RT" <rt-comment@krbdev.mit.edu>
Reply-To: rt-comment@krbdev.mit.edu
Mail-Copies-To: never
Cc: krb5-prs@mit.edu
Errors-To: krb5-bugs-admin@mit.edu
Date: Fri, 11 Oct 2002 15:17:43 -0400 (EDT)

On Thu, Oct 10, 2002 at 07:27:21PM -0400, Tom Yu via RT wrote:
> Thanks for the patch...
[snip]
> nalin> @@ -463,6 +463,8 @@
> nalin>          CHECK(p,2);
> nalin>  	rdlen = NTOHSP(p,2);
>  
> nalin> +	CHECK(p,rdlen);
> nalin> +
> 
> Could you please explain why this check for rdlen was added?  It seems
> redundant.

Oh, you're right.  I was trying to guard against missing data for other
RR types, but there's an else block around line 520 that already does
the job.

Thanks,

Nalin

_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
http://mailman.mit.edu/mailman/listinfo/krb5-bugs

home help back first fref pref prev next nref lref last post