[343] in Kerberos-V5-bugs
Re: memory leak in krb5_free_cred_enc_part
daemon@ATHENA.MIT.EDU (Theodore Ts'o)
Fri Sep 17 18:55:26 1993
Date: Fri, 17 Sep 93 18:45:03 EDT
From: tytso@MIT.EDU (Theodore Ts'o)
To: jim@bilbo.suite.com (Jim Miller)
Cc: krb5-bugs@MIT.EDU, kerberos@MIT.EDU
In-Reply-To: "[340] in Kerberos-V5-bugs"
Hi,
Could you please tell me where you got your Kerberos "pre-beta3"
distribution from which you've been sending patches? Neither the beta 2
distribution, the pre-beta 3 distribution I sent out, or the current MIT
source tree has any reference to a krb5_cred_info structure. In
addition the f_cred_enc.c which was distributed in the pre-beta3
distribution looks nothing like the one you included:
void
krb5_free_cred_enc_part(val)
register krb5_cred_enc_part *val;
{
register krb5_cred_enc_struct **temp;
for (temp = val->creds; *temp; temp++) {
if ((*temp)->session)
krb5_free_keyblock((*temp)->session);
if ((*temp)->r_address)
krb5_free_address((*temp)->r_address);
if ((*temp)->s_address)
krb5_free_address((*temp)->s_address);
if ((*temp)->client)
krb5_free_principal((*temp)->client);
if ((*temp)->server)
krb5_free_principal((*temp)->server);
if ((*temp)->caddrs)
krb5_free_addresses((*temp)->caddrs);
xfree((*temp));
}
xfree(val);
return;
}
Something confusing is going on here, and I hope we can figure out what
it is. Thanks for sending in bug reports, though --- I'm really glad
you're taking the time to go through the code with a fine toothed comb,
as you obviously are. Let's just figure out what that code actually is. :-)
- Ted
