[3402] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

[krbdev.mit.edu #1164] bogus return value from krb5_auth_con_genaddrs()

daemon@ATHENA.MIT.EDU (zacheiss@MIT.EDU via RT)
Tue Aug 27 18:29:15 2002

Message-Id: <rt-1164-2776.7.90084332208565@krbdev.mit.edu>
In-Reply-To: <rt-1164@krbdev.mit.edu>
From: "zacheiss@MIT.EDU via RT" <rt-comment@krbdev.mit.edu>
Reply-To: rt-comment@krbdev.mit.edu
To: krb5-prs@mit.edu
Errors-To: krb5-bugs-admin@mit.edu
Date: Tue, 27 Aug 2002 18:28:45 -0400 (EDT)


	This code exists in krb5_auth_con_genaddrs():

    if ((flags & KRB5_AUTH_CONTEXT_GENERATE_REMOTE_FULL_ADDR) ||
        (flags & KRB5_AUTH_CONTEXT_GENERATE_REMOTE_ADDR)) {
        if ((retval = getpeername(fd, (struct sockaddr *) &rsaddr, &ssize)))
            return retval;

	This is unfortunate because getpeername returns -1 and sets
errno on error; passing -1 to com_err gets you a useless "____ 255" as
your error message.

	Returning errno would be an improvement over the current
situation, but returning something more meaningful would be even better.

Garry
_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
http://mailman.mit.edu/mailman/listinfo/krb5-bugs

home help back first fref pref prev next nref lref last post