[3254] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

krb5-libs/999: init_ctx error

daemon@ATHENA.MIT.EDU (ratliff@austin.ibm.com)
Mon Oct 1 18:22:57 2001

Resent-From: gnats@rt-11.mit.edu (GNATS Management)
Resent-To: krb5-unassigned@rt-11.mit.edu
Resent-Reply-To: krb5-bugs@MIT.EDU, ratliff@austin.ibm.com
Message-Id: <20011001221940.1B10D82C06@spiff.austin.ibm.com>
Date: Mon,  1 Oct 2001 17:19:40 -0500 (CDT)
From: ratliff@austin.ibm.com
Reply-To: ratliff@austin.ibm.com
To: krb5-bugs@MIT.EDU, ratliff@austin.ibm.com


>Number:         999
>Category:       krb5-libs
>Synopsis:       default value thrown away in init_ctx
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    krb5-unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Mon Oct  1 18:20:00 EDT 2001
>Last-Modified:
>Originator:     Emily Ratliff
>Organization:
IBM Linux Technology Center, Security
>Release:        krb5-current
>Environment:
	
System: Linux spiff.austin.ibm.com 2.2.17-21mdk #1 Thu Oct 5 13:16:08 CEST 2000 i686 unknown
Architecture: i686

>Description:
	In init_common() in lib/krb5/krb/init_ctx.c there is a call to
	profile_get_integer to get kdc_default_options with a default of
	KDC_OPT_RENEWABLE_OK and the returned value stored in tmp.
	The assignment on the next line assigns KDC_OPT_RENEWABLE_OK and
	ignores the value returned in tmp. Either the call should be
	removed or the returned value should be honored. Perhaps this
	was a work-around, in which case it should be documented.
>How-To-Repeat:
	Look at code on lines 190-191 in lib/krb5/krb/init_ctx.c from
	9/29's krb5-current.
>Fix:

diff -ur src.old/lib/krb5/krb/init_ctx.c src/lib/krb5/krb/init_ctx.c
--- src.old/lib/krb5/krb/init_ctx.c	Mon Oct  1 16:55:51 2001
+++ src/lib/krb5/krb/init_ctx.c	Mon Oct  1 17:08:45 2001
@@ -190,7 +190,7 @@
 	profile_get_integer(ctx->profile, "libdefaults",
 			    "kdc_default_options", 0,
 			    KDC_OPT_RENEWABLE_OK, &tmp);
-	ctx->kdc_default_options = KDC_OPT_RENEWABLE_OK;
+	ctx->kdc_default_options = tmp;
 #ifdef macintosh
 #define DEFAULT_KDC_TIMESYNC 1
 #else
>Audit-Trail:
>Unformatted:

home help back first fref pref prev next nref lref last post