[3187] in Kerberos-V5-bugs
pending/932: Patch for Linux-IA64
daemon@ATHENA.MIT.EDU (Michael Madore)
Fri Mar 23 14:26:06 2001
Resent-From: gnats@rt-11.mit.edu (GNATS Management)
Resent-To: gnats-admin@rt-11.mit.edu
Resent-Reply-To: krb5-bugs@MIT.EDU, Michael Madore <mmadore@turbolinux.com>
Message-Id: <20010323112507.E8468@drevil.no>
Date: Fri, 23 Mar 2001 11:25:07 -0800
From: Michael Madore <mmadore@turbolinux.com>
To: krb5-bugs@mit.edu
>Number: 932
>Category: pending
>Synopsis: Patch for Linux-IA64
>Confidential: yes
>Severity: serious
>Priority: medium
>Responsible: gnats-admin
>State: open
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Fri Mar 23 14:26:01 EST 2001
>Last-Modified:
>Originator:
>Organization:
>Release:
>Environment:
>Description:
>How-To-Repeat:
>Fix:
>Audit-Trail:
>Unformatted:
--9amGYk9869ThD9tj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Hi,
Here is a small patch I created for Linux-IA64 to get rid of warnings due to
missing function prototypes from string.h, and a integer -> pointer
conversion warnings. Without string.h, gcc assumes the function return
integer. On Linux-IA64 integers are 32 bits while pointers are 64 bits.
String functions which return pointers will have them trashed if they are
converted to ints.
--
Mike Madore
Software Engineer
TurboLinux, Inc.
--9amGYk9869ThD9tj
Content-Type: application/x-patch
Content-Disposition: attachment; filename="krb5-1.2.1-ia64.patch"
diff -Nur krb5-1.2.1/src/appl/telnet/telnetd/sys_term.c krb5-1.2.1.new/src/appl/telnet/telnetd/sys_term.c
--- krb5-1.2.1/src/appl/telnet/telnetd/sys_term.c Thu Jun 29 19:27:13 2000
+++ krb5-1.2.1.new/src/appl/telnet/telnetd/sys_term.c Fri Mar 23 10:20:26 2001
@@ -1430,7 +1430,7 @@
;
if (cpp == &argv[(int)argv[-1]]) {
--argv;
- *argv = (char *)((int)(*argv) + 10);
+ *argv = (char *)((*argv) + 10);
argv = (char **)realloc(argv, (int)(*argv) + 2);
if (argv == NULL)
return(NULL);
diff -Nur krb5-1.2.1/src/appl/user_user/server.c krb5-1.2.1.new/src/appl/user_user/server.c
--- krb5-1.2.1/src/appl/user_user/server.c Thu Jun 29 19:27:13 2000
+++ krb5-1.2.1.new/src/appl/user_user/server.c Fri Mar 23 10:03:59 2001
@@ -33,6 +33,7 @@
#include <arpa/inet.h>
#include <netdb.h>
#include <stdio.h>
+#include <string.h>
#include <fcntl.h>
#include "krb5.h"
diff -Nur krb5-1.2.1/src/kadmin/v4server/kadm_supp.c krb5-1.2.1.new/src/kadmin/v4server/kadm_supp.c
--- krb5-1.2.1/src/kadmin/v4server/kadm_supp.c Thu Jun 29 19:27:42 2000
+++ krb5-1.2.1.new/src/kadmin/v4server/kadm_supp.c Fri Mar 23 10:03:24 2001
@@ -12,6 +12,7 @@
#include <mit-copyright.h>
#include <stdio.h>
+#include <string.h>
#ifdef HAVE_UNISTD_H
#include <unistd.h>
#endif
diff -Nur krb5-1.2.1/src/lib/gssapi/generic/util_validate.c krb5-1.2.1.new/src/lib/gssapi/generic/util_validate.c
--- krb5-1.2.1/src/lib/gssapi/generic/util_validate.c Thu Jun 29 19:27:56 2000
+++ krb5-1.2.1.new/src/lib/gssapi/generic/util_validate.c Fri Mar 23 10:54:08 2001
@@ -30,6 +30,7 @@
#include "gssapiP_generic.h"
+#include <inttypes.h>
#ifdef HAVE_SYS_TYPES_H
#include <sys/types.h>
#endif
@@ -81,7 +82,7 @@
if (g_set_init(gs))
return(0);
- return(g_set_entry_add(gs, ptr, (void *) type) == 0);
+ return(g_set_entry_add(gs, ptr, (void *) (intptr_t) type) == 0);
#endif
}
diff -Nur krb5-1.2.1/src/lib/rpc/clnt_generic.c krb5-1.2.1.new/src/lib/rpc/clnt_generic.c
--- krb5-1.2.1/src/lib/rpc/clnt_generic.c Thu Jun 29 19:28:14 2000
+++ krb5-1.2.1.new/src/lib/rpc/clnt_generic.c Fri Mar 23 09:57:36 2001
@@ -37,6 +37,7 @@
#include <sys/socket.h>
#include <sys/errno.h>
#include <netdb.h>
+#include <string.h>
/*
* Generic client creation: takes (hostname, program-number, protocol) and
diff -Nur krb5-1.2.1/src/lib/rpc/pmap_rmt.c krb5-1.2.1.new/src/lib/rpc/pmap_rmt.c
--- krb5-1.2.1/src/lib/rpc/pmap_rmt.c Thu Jun 29 19:28:14 2000
+++ krb5-1.2.1.new/src/lib/rpc/pmap_rmt.c Fri Mar 23 09:58:08 2001
@@ -49,6 +49,7 @@
#endif
#include <stdio.h>
#include <errno.h>
+#include <string.h>
#ifdef OSF1
#include <net/route.h>
#include <sys/mbuf.h>
diff -Nur krb5-1.2.1/src/lib/rpc/svc.c krb5-1.2.1.new/src/lib/rpc/svc.c
--- krb5-1.2.1/src/lib/rpc/svc.c Thu Jun 29 19:28:14 2000
+++ krb5-1.2.1.new/src/lib/rpc/svc.c Fri Mar 23 09:58:21 2001
@@ -45,6 +45,7 @@
#include <gssrpc/rpc.h>
#include <gssrpc/pmap_clnt.h>
#include <stdio.h>
+#include <string.h>
extern int errno;
diff -Nur krb5-1.2.1/src/lib/rpc/svc_simple.c krb5-1.2.1.new/src/lib/rpc/svc_simple.c
--- krb5-1.2.1/src/lib/rpc/svc_simple.c Thu Jun 29 19:28:15 2000
+++ krb5-1.2.1.new/src/lib/rpc/svc_simple.c Fri Mar 23 09:58:33 2001
@@ -39,6 +39,7 @@
*/
#include <stdio.h>
+#include <string.h>
#include <gssrpc/rpc.h>
#include <sys/socket.h>
#include <netdb.h>
diff -Nur krb5-1.2.1/src/lib/rpc/svc_tcp.c krb5-1.2.1.new/src/lib/rpc/svc_tcp.c
--- krb5-1.2.1/src/lib/rpc/svc_tcp.c Thu Jun 29 19:28:15 2000
+++ krb5-1.2.1.new/src/lib/rpc/svc_tcp.c Fri Mar 23 09:58:50 2001
@@ -42,6 +42,7 @@
*/
#include <stdio.h>
+#include <string.h>
#include <gssrpc/rpc.h>
#include <sys/socket.h>
#include <errno.h>
diff -Nur krb5-1.2.1/src/lib/rpc/svc_udp.c krb5-1.2.1.new/src/lib/rpc/svc_udp.c
--- krb5-1.2.1/src/lib/rpc/svc_udp.c Thu Jun 29 19:28:15 2000
+++ krb5-1.2.1.new/src/lib/rpc/svc_udp.c Fri Mar 23 09:59:02 2001
@@ -40,6 +40,7 @@
*/
#include <stdio.h>
+#include <string.h>
#include <gssrpc/rpc.h>
#include <sys/socket.h>
#include <errno.h>
diff -Nur krb5-1.2.1/src/lib/rpc/unit-test/client.c krb5-1.2.1.new/src/lib/rpc/unit-test/client.c
--- krb5-1.2.1/src/lib/rpc/unit-test/client.c Thu Jun 29 19:28:15 2000
+++ krb5-1.2.1.new/src/lib/rpc/unit-test/client.c Fri Mar 23 10:01:18 2001
@@ -95,6 +95,7 @@
#endif
#include <stdio.h>
+#include <string.h>
#include <gssrpc/rpc.h>
#include <gssapi/gssapi.h>
#include <gssrpc/rpc.h>
diff -Nur krb5-1.2.1/src/lib/rpc/unit-test/rpc_test_clnt.c krb5-1.2.1.new/src/lib/rpc/unit-test/rpc_test_clnt.c
--- krb5-1.2.1/src/lib/rpc/unit-test/rpc_test_clnt.c Thu Jun 29 19:28:15 2000
+++ krb5-1.2.1.new/src/lib/rpc/unit-test/rpc_test_clnt.c Fri Mar 23 10:01:35 2001
@@ -1,4 +1,5 @@
#include "rpc_test.h"
+#include <string.h>
/* Default timeout can be changed using clnt_control() */
static struct timeval TIMEOUT = { 25, 0 };
diff -Nur krb5-1.2.1/src/lib/rpc/unit-test/rpc_test_svc.c krb5-1.2.1.new/src/lib/rpc/unit-test/rpc_test_svc.c
--- krb5-1.2.1/src/lib/rpc/unit-test/rpc_test_svc.c Thu Jun 29 19:28:15 2000
+++ krb5-1.2.1.new/src/lib/rpc/unit-test/rpc_test_svc.c Fri Mar 23 10:01:53 2001
@@ -1,5 +1,6 @@
#include "rpc_test.h"
#include <stdio.h>
+#include <string.h>
#include <stdlib.h> /* getenv, exit */
#include <sys/types.h>
#include <syslog.h>
diff -Nur krb5-1.2.1/src/lib/rpc/xdr_array.c krb5-1.2.1.new/src/lib/rpc/xdr_array.c
--- krb5-1.2.1/src/lib/rpc/xdr_array.c Thu Jun 29 19:28:15 2000
+++ krb5-1.2.1.new/src/lib/rpc/xdr_array.c Fri Mar 23 09:59:17 2001
@@ -41,6 +41,7 @@
*/
#include <stdio.h>
+#include <string.h>
#include <gssrpc/types.h>
#include <gssrpc/xdr.h>
diff -Nur krb5-1.2.1/src/lib/rpc/xdr_reference.c krb5-1.2.1.new/src/lib/rpc/xdr_reference.c
--- krb5-1.2.1/src/lib/rpc/xdr_reference.c Thu Jun 29 19:28:15 2000
+++ krb5-1.2.1.new/src/lib/rpc/xdr_reference.c Fri Mar 23 09:59:32 2001
@@ -41,6 +41,7 @@
*/
#include <stdio.h>
+#include <string.h>
#include <gssrpc/types.h>
#include <gssrpc/xdr.h>
diff -Nur krb5-1.2.1/src/tests/asn.1/trval.c krb5-1.2.1.new/src/tests/asn.1/trval.c
--- krb5-1.2.1/src/tests/asn.1/trval.c Thu Jun 29 19:28:28 2000
+++ krb5-1.2.1.new/src/tests/asn.1/trval.c Fri Mar 23 10:20:51 2001
@@ -36,6 +36,7 @@
*****************************************************************************/
#include <unistd.h>
+#include <string.h>
#include <stdlib.h>
#include <stdio.h>
#include <ctype.h>
diff -Nur krb5-1.2.1/src/util/profile/argv_parse.c krb5-1.2.1.new/src/util/profile/argv_parse.c
--- krb5-1.2.1/src/util/profile/argv_parse.c Thu Jun 29 19:28:50 2000
+++ krb5-1.2.1.new/src/util/profile/argv_parse.c Fri Mar 23 09:50:48 2001
@@ -29,6 +29,7 @@
*/
#include <stdlib.h>
+#include <string.h>
#include <ctype.h>
#include "argv_parse.h"
diff -Nur krb5-1.2.1/src/util/profile/test_profile.c krb5-1.2.1.new/src/util/profile/test_profile.c
--- krb5-1.2.1/src/util/profile/test_profile.c Thu Jun 29 19:28:51 2000
+++ krb5-1.2.1.new/src/util/profile/test_profile.c Fri Mar 23 09:50:36 2001
@@ -3,6 +3,7 @@
*/
#include <stdio.h>
+#include <string.h>
#ifdef HAVE_STDLIB_H
#include <stdlib.h>
#endif
--9amGYk9869ThD9tj--
