[3150] in Kerberos-V5-bugs
krb5-libs/787: Replay cache code shouldn't call fsync() after every entry is written
daemon@ATHENA.MIT.EDU (Jonathan Kamens)
Tue Nov 23 16:52:11 1999
Resent-From: gnats@rt-11.MIT.EDU (GNATS Management)
Resent-To: krb5-unassigned@RT-11.MIT.EDU
Resent-Reply-To: krb5-bugs@MIT.EDU, jik@kamens.brookline.ma.us
Message-Id: <199911232151.QAA21023@jik2.kamens.brookline.ma.us>
Date: Tue, 23 Nov 1999 16:51:58 -0500
From: Jonathan Kamens <jik@kamens.brookline.ma.us>
Reply-To: jik@kamens.brookline.ma.us
To: krb5-bugs@MIT.EDU
>Number: 787
>Category: krb5-libs
>Synopsis: Replay cache code shouldn't call fsync() after every entry is written
>Confidential: yes
>Severity: non-critical
>Priority: medium
>Responsible: krb5-unassigned
>State: open
>Class: change-request
>Submitter-Id: unknown
>Arrival-Date: Tue Nov 23 16:52:00 EST 1999
>Last-Modified:
>Originator: Jonathan Kamens
>Organization:
>Release: krb5-1.1
>Environment:
System: Linux jik2 2.2.12-20 #14 Thu Nov 18 20:57:02 EST 1999 i686 unknown
Architecture: i686
>Description:
The replay cache code shouldn't call fsync() after every entry
is written into the replay cache. There's no point to it, and
it significantly hurts performance and thrashes the disk
unnecessarily when a server is receiving a lot of requests.
>How-To-Repeat:
>Fix:
Index: ./src/lib/krb5/rcache/rc_dfl.c
--- rc_dfl.c 1999/11/23 20:50:58 1.1.1.1
+++ rc_dfl.c 1999/11/23 21:36:37 1.3
@@ -532,13 +532,6 @@
{
return krb5_rc_dfl_expunge(context, id);
}
-#ifndef NOIOSTUFF
- else
- {
- if (krb5_rc_io_sync(context, &t->d))
- return KRB5_RC_IO;
- }
-#endif
return 0;
}
>Audit-Trail:
>Unformatted:
