[3133] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

krb5-libs/770: Use of "errno" in prototype

daemon@ATHENA.MIT.EDU (ghudson@MIT.EDU)
Sun Oct 10 22:17:21 1999

Resent-From: gnats@rt-11.MIT.EDU (GNATS Management)
Resent-To: krb5-unassigned@RT-11.MIT.EDU
Resent-Reply-To: krb5-bugs@MIT.EDU, ghudson@MIT.EDU
Message-Id: <199910110216.WAA10311@small-gods.mit.edu>
Date: Sun, 10 Oct 1999 22:16:28 -0400 (EDT)
From: ghudson@MIT.EDU
Reply-To: ghudson@MIT.EDU
To: krb5-bugs@MIT.EDU


>Number:         770
>Category:       krb5-libs
>Synopsis:       krb4 prototype uses parameter name "errno"
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    krb5-unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Sun Oct 10 22:17:01 EDT 1999
>Last-Modified:
>Originator:     Greg Hudson
>Organization:
mit
>Release:        1.0
>Environment:
	
System: SunOS small-gods.mit.edu 5.6 Generic_105181-13 sun4u sparc SUNW,Ultra-5_10
Architecture: sun4

>Description:
errno is sometimes a macro.  It should not be used as a parameter name
in prototypes.
>How-To-Repeat:
Compile something using krb_get_err_text() with gcc -Wall.
>Fix:
The function definition already uses "code".

Index: krb.h
===================================================================
RCS file: /afs/dev.mit.edu/source/repository/third/krb5/src/include/kerberosIV/krb.h,v
retrieving revision 1.9
diff -c -r1.9 krb.h
*** krb.h	1999/10/07 00:58:31	1.9
--- krb.h	1999/10/11 02:13:34
***************
*** 466,472 ****
  	PROTOTYPE((void));
  /* err_txt.c */
  KRB5_DLLIMP const char FAR * KRB5_CALLCONV krb_get_err_text
! 	PROTOTYPE((int errno));
  /* g_ad_tkt.c */
  int get_ad_tkt
  	PROTOTYPE((char *service, char *sinst, char *realm, int lifetime));
--- 466,472 ----
  	PROTOTYPE((void));
  /* err_txt.c */
  KRB5_DLLIMP const char FAR * KRB5_CALLCONV krb_get_err_text
! 	PROTOTYPE((int code));
  /* g_ad_tkt.c */
  int get_ad_tkt
  	PROTOTYPE((char *service, char *sinst, char *realm, int lifetime));
>Audit-Trail:
>Unformatted:

home help back first fref pref prev next nref lref last post