[2991] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

krb5-libs/653: krb5_md5_sum_func uses hardcoded `16' as checksum length

daemon@ATHENA.MIT.EDU (fcusack@iconnet.net)
Thu Oct 29 20:59:47 1998

Resent-From: gnats@rt-11.MIT.EDU (GNATS Management)
Resent-To: krb5-unassigned@RT-11.MIT.EDU
Resent-Reply-To: krb5-bugs@MIT.EDU, fcusack@iconnet.net
Date: Thu, 29 Oct 1998 20:54:13 -0500 (EST)
From: fcusack@iconnet.net
Reply-To: fcusack@iconnet.net
To: krb5-bugs@MIT.EDU


>Number:         653
>Category:       krb5-libs
>Synopsis:       krb5_md5_sum_func uses hardcoded `16' as checksum length
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    krb5-unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Thu Oct 29 20:54:01 EST 1998
>Last-Modified:
>Originator:     Frank Cusack
>Organization:
Icon CMT Corp.
>Release:        krb5-current-19981012
>Environment:
N/A
System: SunOS ratbert 5.6 Generic_105181-09 sun4u sparc SUNW,Ultra-5_10
Architecture: sun4

>Description:
See Fix
>How-To-Repeat:
N/A
>Fix:
diff -u -r1.1.1.1 md5glue.c
--- md5glue.c   1998/10/14 00:47:05     1.1.1.1
+++ md5glue.c   1998/10/30 01:53:22
@@ -40,7 +40,8 @@
     outcksum->checksum_type = CKSUMTYPE_RSA_MD5;
     outcksum->length = RSA_MD5_CKSUM_LENGTH;
 
-    memcpy((char *)outcksum->contents, (char *)&working.digest[0], 16);
+    memcpy((char *)outcksum->contents, (char *)&working.digest[0],
+           RSA_MD5_CKSUM_LENGTH);
 
     memset((char *)&working, 0, sizeof(working));
     return 0;

>Audit-Trail:
>Unformatted:

home help back first fref pref prev next nref lref last post