[2989] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

krb5-admin/651: kadmin headers are not installed

daemon@ATHENA.MIT.EDU (danw@MIT.EDU)
Tue Oct 27 17:24:21 1998

Resent-From: gnats@rt-11.MIT.EDU (GNATS Management)
Resent-To: bjaspan@MIT.EDU
Resent-Reply-To: krb5-bugs@MIT.EDU, danw@MIT.EDU
Date: Tue, 27 Oct 1998 17:11:52 -0500
From: danw@MIT.EDU
Reply-To: danw@MIT.EDU
To: krb5-bugs@MIT.EDU


>Number:         651
>Category:       krb5-admin
>Synopsis:       kadmin headers are not installed
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    bjaspan
>State:          open
>Class:          change-request
>Submitter-Id:   unknown
>Arrival-Date:   Tue Oct 27 17:12:01 EST 1998
>Last-Modified:
>Originator:     Dan Winship
>Organization:
MIT
>Release:        1.0
>Environment:
	
System: IRIX antharia 6.3 12161207 IP32


>Description:
	The kadmin headers are not installed. This is bad because people
	might want to write custom kadmin clients.

	For example, instead of creating every new kerberos principal
	by hand in kadmin, a large site might want to have a
	"registration server" that users interact with to cause a new
	Kerberos principal be created for them. Presumably the authors
	of such a program would expect to be able to compile it without
	needing to have a krb5 build tree handy to suck include files
	out of. Or at least, one imagines they would expect this. :-)

>How-To-Repeat:
	
>Fix:
	This isn't tested. You also might want to do something different
	in kadm5/admin.h where I had to change some things to remove
	the k5-int.h include.

Index: config/pre.in
===================================================================
RCS file: /cvs/krbdev/krb5/src/config/pre.in,v
retrieving revision 1.50
diff -c -r1.50 pre.in
*** pre.in	1998/04/15 22:09:19	1.50
--- pre.in	1998/10/27 21:47:36
***************
*** 112,117 ****
--- 112,119 ----
  KRB5_INCSUBDIRS = \
  	$(KRB5_INCDIR)/asn.1 \
  	$(KRB5_INCDIR)/gssapi \
+ 	$(KRB5_INCDIR)/gssrpc \
+ 	$(KRB5_INCDIR)/kadm5 \
  	$(KRB5_INCDIR)/kerberosIV
  
  #
Index: lib/kadm5/Makefile.in
===================================================================
RCS file: /cvs/krbdev/krb5/src/lib/kadm5/Makefile.in,v
retrieving revision 1.11
diff -c -r1.11 Makefile.in
*** Makefile.in	1998/04/06 23:44:44	1.11
--- Makefile.in	1998/10/27 21:47:53
***************
*** 67,72 ****
--- 67,74 ----
  SRC_HDRS = adb.h admin.h admin_internal.h admin_xdr.h kadm_rpc.h \
  		server_internal.h 
  
+ INST_HDRS = admin.h kadm_err.h adb_err.h chpass_util_strings.h
+ 
  includes:: $(SRC_HDRS) $(BUILD_HDRS)
  	if [ -d $(HDRDIR) ]; then :; else mkdir -p $(HDRDIR); fi
  	for i in $(SRC_HDRS) ; do \
***************
*** 98,100 ****
--- 100,107 ----
  
  clean-mac::
  clean-windows::
+ 
+ install::
+ 	@set -x; for f in $(INST_HDRS) ; \
+ 	do $(INSTALL_DATA) $(srcdir)/$$f $(DESTDIR)$(KRB5_INCDIR)/kadm5/$$f ; \
+ 	done
Index: lib/kadm5/admin.h
===================================================================
RCS file: /cvs/krbdev/krb5/src/lib/kadm5/admin.h,v
retrieving revision 1.40
diff -c -r1.40 admin.h
*** admin.h	1998/02/14 02:34:09	1.40
--- admin.h	1998/10/27 21:47:53
***************
*** 14,20 ****
  #include	<sys/types.h>
  #include	<gssrpc/rpc.h>
  #include	<krb5.h>
- #include	<k5-int.h>
  #include	<com_err.h>
  #include	<kadm5/kadm_err.h>
  #include	<kadm5/adb_err.h>
--- 14,19 ----
***************
*** 138,145 ****
          krb5_kvno fail_auth_count;
  	krb5_int16 n_key_data;
  	krb5_int16 n_tl_data;
!         krb5_tl_data *tl_data;
! 	krb5_key_data *key_data;
  } kadm5_principal_ent_rec_v2, *kadm5_principal_ent_t_v2;
  
  typedef struct _kadm5_principal_ent_t_v1 {
--- 137,144 ----
          krb5_kvno fail_auth_count;
  	krb5_int16 n_key_data;
  	krb5_int16 n_tl_data;
!         struct _krb5_tl_data *tl_data;
! 	struct _krb5_key_data *key_data;
  } kadm5_principal_ent_rec_v2, *kadm5_principal_ent_t_v2;
  
  typedef struct _kadm5_principal_ent_t_v1 {
***************
*** 403,409 ****
  #if USE_KADM5_API_VERSION > 1
  kadm5_ret_t    kadm5_free_key_data(void *server_handle,
  				   krb5_int16 *n_key_data,
! 				   krb5_key_data *key_data);
  #endif
  
  #if USE_KADM5_API_VERSION == 1
--- 402,408 ----
  #if USE_KADM5_API_VERSION > 1
  kadm5_ret_t    kadm5_free_key_data(void *server_handle,
  				   krb5_int16 *n_key_data,
! 				   struct _krb5_key_data *key_data);
  #endif
  
  #if USE_KADM5_API_VERSION == 1
Index: lib/kadm5/clnt/client_principal.c
===================================================================
RCS file: /cvs/krbdev/krb5/src/lib/kadm5/clnt/client_principal.c,v
retrieving revision 1.6
diff -c -r1.6 client_principal.c
*** client_principal.c	1998/02/14 02:32:56	1.6
--- client_principal.c	1998/10/27 21:47:53
***************
*** 8,13 ****
--- 8,14 ----
  static char *rcsid = "$Header: /cvs/krbdev/krb5/src/lib/kadm5/clnt/client_principal.c,v 1.6 1998/02/14 02:32:56 tlyu Exp $";
  #endif
  
+ #include    <k5-int.h>
  #include    <gssrpc/rpc.h>
  #include    <kadm5/admin.h>
  #include    <kadm5/kadm_rpc.h>
Index: lib/rpc/Makefile.in
===================================================================
RCS file: /cvs/krbdev/krb5/src/lib/rpc/Makefile.in,v
retrieving revision 1.18
diff -c -r1.18 Makefile.in
*** Makefile.in	1998/04/15 22:14:48	1.18
--- Makefile.in	1998/10/27 21:48:04
***************
*** 199,204 ****
--- 199,212 ----
  		fi ; \
  	done
  
+ install-unix::
+ 	@set -x; for f in $(SRC_HDRS) ; do \
+ 		$(INSTALL_DATA) $(srcdir)/$$f $(DESTDIR)$(KRB5_INCDIR)/gssrpc/$$f ; \
+ 	done
+ 	@set -x; for f in $(BUILD_HDRS) ; do \
+ 		$(INSTALL_DATA) $$f $(DESTDIR)$(KRB5_INCDIR)/gssrpc/$$f ; \
+ 	done
+ 
  clean-unix::
  	$(RM) $(HDRS)
  	for i in $(SRC_HDRS) $(BUILD_HDRS) ; do \
>Audit-Trail:
>Unformatted:

home help back first fref pref prev next nref lref last post