[2873] in Kerberos-V5-bugs
pty/544: ptyXX pty's are never found
daemon@ATHENA.MIT.EDU (Manish Vachharajani)
Tue Feb 3 20:57:51 1998
Resent-From: gnats@rt-11.MIT.EDU (GNATS Management)
Resent-To: hartmans@MIT.EDU
Resent-Reply-To: krb5-bugs@MIT.EDU, mvachhar@pythagoras.rutgers.edu
Date: Tue, 3 Feb 1998 20:56:15 -0500
From: Manish Vachharajani <mvachhar@pythagoras.rutgers.edu>
Reply-To: mvachhar@pythagoras.rutgers.edu
To: krb5-bugs@MIT.EDU
>Number: 544
>Category: pty
>Synopsis: ptyXX pty's are never found
>Confidential: no
>Severity: critical
>Priority: medium
>Responsible: hartmans
>State: open
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Tue Feb 03 20:57:01 EST 1998
>Last-Modified:
>Originator: Manish Vachharajani
>Organization:
Manish Vachharajani <mvachhar@noc.rutgers.edu>
Rutgers University http://www.rutgers.net/~mvachhar
Telecommunications Division
Systems Programmer
>Release: krb5-1.0.4
>Environment:
System: Linux pythagoras.rutgers.edu 2.0.30 #1 Tue Apr 22 11:32:12 EDT 1997 sparc unknown
Architecture: sparc
>Description:
The ptyXX ptys are never found since it looks for ptyXp0 etc.
>How-To-Repeat:
Just use telnetd or rlogind on a machine with no /dev/pty or equivalent, no
openpty etc. It will fail to find any pty's and return an error
>Fix:
Here is a patch
--- krb5-1.0.4/src/util/pty/getpty.c.orig Tue Feb 3 16:41:22 1998
+++ krb5-1.0.4/src/util/pty/getpty.c Tue Feb 3 16:41:39 1998
@@ -111,8 +111,8 @@
} else {
for (cp = "pqrstuvwxyzPQRST";*cp; cp++) {
sprintf(slavebuf,"/dev/ptyXX");
- slavebuf[sizeof("/dev/pty")] = *cp;
- slavebuf[sizeof("/dev/ptyp")] = '0';
+ slavebuf[sizeof("/dev/pty") - 1 ] = *cp;
+ slavebuf[sizeof("/dev/ptyp") - 1 ] = '0';
if (stat(slavebuf, &stb) < 0)
break;
for (i = 0; i < 16; i++) {
>Audit-Trail:
>Unformatted:
