[2841] in Kerberos-V5-bugs
krb5-appl/513: ncurses doesn't have ttytype[], with patch
daemon@ATHENA.MIT.EDU (evanc@synapse.net)
Sun Dec 7 11:03:12 1997
Resent-From: gnats@rt-11.MIT.EDU (GNATS Management)
Resent-To: krb5-unassigned@RT-11.MIT.EDU
Resent-Reply-To: krb5-bugs@MIT.EDU, evanc@synapse.net
Date: 7 Dec 1997 16:02:47 -0000
From: evanc@synapse.net
To: krb5-bugs@MIT.EDU
Cc: evanc@synapse.net
>Number: 513
>Category: krb5-appl
>Synopsis: ncurses doesn't have ttytype[], with patch
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: krb5-unassigned
>State: open
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Sun Dec 07 11:03:01 EST 1997
>Last-Modified:
>Originator: Evan Champion
>Organization:
>Release: krb5-1.0.4
>Environment:
System: FreeBSD cello.synapse.net 3.0-CURRENT FreeBSD 3.0-CURRENT #0: Sat Dec 6 16:07:02 EST 1997 evanc@cello.synapse.net:/usr/src/sys/compile/CELLO i386
>Description:
I have setupterm(), but not extern char ttytype[] -- it is not a
part of ncurses. This prevents telnet from compiling if it finds
setupterm().
I don't think that there is much to be gained from using the
ttytype[] as opposed to termbuf[], so I moved the termbuf[]
declaration outside the #ifdef, and removed the ttytype[]
#define/extern.
>How-To-Repeat:
>Fix:
*** 1/krb5-1.0.4/src/appl/telnet/telnet/telnet.c Thu Dec 4 22:42:20 1997
--- krb5-1.0.4/src/appl/telnet/telnet/telnet.c Sat Dec 6 20:31:52 1997
***************
*** 742,750 ****
return (1);
}
- #ifndef HAVE_SETUPTERM
char termbuf[1024];
/*ARGSUSED*/
int
setupterm(tname, fd, errp)
--- 742,750 ----
return (1);
}
char termbuf[1024];
+ #ifndef HAVE_SETUPTERM
/*ARGSUSED*/
int
setupterm(tname, fd, errp)
***************
*** 761,769 ****
*errp = 0;
return(-1);
}
- #else
- #define termbuf ttytype
- extern char ttytype[];
#endif
int resettermname = 1;
--- 761,766 ----
>Audit-Trail:
>Unformatted: