[2659] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

krb5-libs/367: Win16 credential forwarding

daemon@ATHENA.MIT.EDU (epeisach@MIT.EDU)
Fri Feb 7 13:05:19 1997

Resent-From: gnats@rt-11.MIT.EDU (GNATS Management)
Resent-To: krb5-unassigned@RT-11.MIT.EDU
Resent-Reply-To: krb5-bugs@MIT.EDU, epeisach@MIT.EDU
Date: Fri, 7 Feb 1997 12:59:51 -0500
From: epeisach@MIT.EDU
Reply-To: epeisach@MIT.EDU
To: krb5-bugs@MIT.EDU


>Number:         367
>Category:       krb5-libs
>Synopsis:       Win16 credential forwarding
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    krb5-unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Fri Feb 07 13:00:00 EST 1997
>Last-Modified:
>Originator:     Ezra Peisach
>Organization:
	MIT
>Release:        1.0
>Environment:
System: OSF1 kangaroo.mit.edu V3.2 214 alpha
Machine: alpha
Apparently under Win16
>Description:
An old bug that we missed going to gnats...


From: Doug Engert <DEEngert@anl.gov>
To: krb5-bugs@mit.edu
Subject: k5b6 Windows bug
Date: Tue, 9 Jul 96 08:23:11 CDT


I got ticket forwarding from a windows 3.1 system working this
morning, after I applied the attached change.

krb5_mk_ncred_basic is expecting a krb5_int32, but the krb5_mk_ncred
has ncred defined as an int.  With Windows 16 bit mode, since there is
not prototype for the internal function, a 16 bit value is pased on
the stack, while a 32 bit is expected.

Suggested fixes include: define ncred as krb5_int32, add a prototype,
or type cast the parameter.

*** ,mk_cred.c  Wed Mar 20 22:20:12 1996
--- mk_cred.c   Tue Jul  9 07:53:05 1996
***************
*** 299,305 ****
      }

      /* Setup creds structure */
!     if ((retval = krb5_mk_ncred_basic(context, ppcreds, ncred, keyblock,
                      &replaydata, plocal_fulladdr,
                      premote_fulladdr, pcred))) {
    goto error;
--- 299,305 ----
      }

      /* Setup creds structure */
!     if ((retval = krb5_mk_ncred_basic(context, ppcreds, (krb5_int32)ncred, key
block,
                      &replaydata, plocal_fulladdr,
                      premote_fulladdr, pcred))) {
    goto error;


 

>How-To-Repeat:
>Fix:
>Audit-Trail:
>Unformatted:

home help back first fref pref prev next nref lref last post