[2311] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

telnet/75: telnet "env" subcommand miscounts arguments

daemon@ATHENA.MIT.EDU (John Hawkinson)
Sun Oct 6 19:27:27 1996

Resent-From: gnats@rt-11.MIT.EDU (GNATS Management)
Resent-To: hartmans@MIT.EDU
Resent-Reply-To: krb5-bugs@MIT.EDU, John Hawkinson <jhawk@bbnplanet.com>
Date: Sun, 6 Oct 1996 19:26:26 -0400
From: John Hawkinson <jhawk@bbnplanet.com>
To: krb5-bugs@MIT.EDU


>Number:         75
>Category:       telnet
>Synopsis:       telnet "env" subcommand miscounts arguments
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hartmans
>State:          open
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Sun Oct e 19:27:00 EDT 1996
>Last-Modified:
>Originator:
>Organization:
		 BBN Planet
>Release:        beta-7
>Environment:
System: SunOS all-purpo 4.1.4 4 sun4m
Architecture: sun4

>Description:

The telnet "env" subcommand miscounts the number of arguments that it
gets. This causes it to misprint the word "only" in some cases.

>How-To-Repeat:

telnet> env varval
Need only 1 argument to 'environ varval' command.  'environ ?' for help.

>Fix:

There's a sign error in the code.

*** appl/telnet/telnet/commands.c	1996/10/06 23:10:12	1.1
--- appl/telnet/telnet/commands.c	1996/10/06 23:21:52	1.2
***************
*** 1661,1667 ****
      if (c->narg + 2 != argc) {
  	fprintf(stderr,
  	    "Need %s%d argument%s to 'environ %s' command.  'environ ?' for help.\n",
! 		c->narg < argc + 2 ? "only " : "",
  		c->narg, c->narg == 1 ? "" : "s", c->name);
  	return 0;
      }
--- 1661,1667 ----
      if (c->narg + 2 != argc) {
  	fprintf(stderr,
  	    "Need %s%d argument%s to 'environ %s' command.  'environ ?' for help.\n",
! 		c->narg < argc - 2 ? "only " : "",
  		c->narg, c->narg == 1 ? "" : "s", c->name);
  	return 0;
      }
>Audit-Trail:
>Unformatted:

home help back first fref pref prev next nref lref last post