[2178] in Kerberos-V5-bugs
non-sized types in kadm5
daemon@ATHENA.MIT.EDU (Barry Jaspan)
Wed Aug 21 13:52:34 1996
Date: Wed, 21 Aug 1996 13:52:24 -0400
From: "Barry Jaspan" <bjaspan@MIT.EDU>
To: krb5-bugs@MIT.EDU
The KADM5 system uses some non-sized integer types in a way that they
get passed into XDR functions that actually care about the size (for
example, eight byte longs are passed to xdr_putlong, which expects a
four byte value). OV fixed most/all of these problems when they
ported this code to the Alpha, but Marc re-introduced some of them by
changing the sized types back to long when he ported the code. Buzz.
For now, I'm fixing the problem by requiring callers of kadm5
functions to zero out structures before passing them to the api (thus
preventing stack garbage greater than 2^32-1 from showing up as a
long). But the right solution is to used sized types everywhere in
the kadm5 api that they matter (and, IMHO, everywhere in every api,
period).
Barry