[2087] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

k5b6 Windows bug

daemon@ATHENA.MIT.EDU (Doug Engert)
Tue Jul 9 09:23:30 1996

Date: Tue, 9 Jul 1996 08:23:16 -0500
From: Doug Engert <DEEngert@anl.gov>
To: krb5-bugs@MIT.EDU


I got ticket forwarding from a windows 3.1 system working this
morning, after I applied the attached change.

krb5_mk_ncred_basic is expecting a krb5_int32, but the krb5_mk_ncred
has ncred defined as an int.  With Windows 16 bit mode, since there is
not prototype for the internal function, a 16 bit value is pased on
the stack, while a 32 bit is expected.

Suggested fixes include: define ncred as krb5_int32, add a prototype, 
or type cast the parameter.

*** ,mk_cred.c	Wed Mar 20 22:20:12 1996
--- mk_cred.c	Tue Jul  9 07:53:05 1996
***************
*** 299,305 ****
      }
  
      /* Setup creds structure */
!     if ((retval = krb5_mk_ncred_basic(context, ppcreds, ncred, keyblock,
  				      &replaydata, plocal_fulladdr, 
  				      premote_fulladdr, pcred))) {
  	goto error;
--- 299,305 ----
      }
  
      /* Setup creds structure */
!     if ((retval = krb5_mk_ncred_basic(context, ppcreds, (krb5_int32)ncred, keyblock,
  				      &replaydata, plocal_fulladdr, 
  				      premote_fulladdr, pcred))) {
  	goto error;

 
 Douglas E. Engert  <DEEngert@anl.gov>
 Argonne National Laboratory
 9700 South Cass Avenue
 Argonne, Illinois  60439 
 (708) 252-5444
 PGP Key fingerprint =  20 2B 0C 78 43 8A 9C A6  29 F7 A3 6D 5E 30 A6 7F

home help back first fref pref prev next nref lref last post