[1799] in Kerberos-V5-bugs
Krb5 beta 5 defects
daemon@ATHENA.MIT.EDU (Sean Mullan)
Mon Feb 12 16:07:41 1996
To: krb5-bugs@MIT.EDU
Cc: mullan_s@apollo.hp.com (Sean Mullan), champine@apollo.hp.com
Date: Mon, 12 Feb 1996 16:07:05 -0500
From: Sean Mullan <mullan_s@apollo.hp.com>
Kerberos 5 Beta 5 defects
-------------------------
1) src/lib/krb5/asn.1/glue2.c
The magic fields are missing for the pre-initialized variables
string_list, string_list2, adarr1, authdarr1, adrarr1. Diffs:
--- glue2.c Mon Feb 12 11:26:24 1996
***************
*** 1,17 ****
#include "krb5.h"
krb5_data string_list[3] = {
! {14, "ATHENA.MIT.EDU"},
! {6, "jtkohl"},
! {4, "root"},
};
krb5_data *princ[] = {&string_list[0], &string_list[1], &string_list[2], 0};
krb5_data string_list2[3] = {
! {14, "ATHENA.MIT.EDU"},
! {6, "krbtgt"},
! {14, "ATHENA.MIT.EDU"},
};
krb5_data *princ2[] = {&string_list2[0], &string_list2[1], &string_list2[2], 0};
--- 1,17 ----
#include "krb5.h"
krb5_data string_list[3] = {
! {0, 14, "ATHENA.MIT.EDU"},
! {0, 6, "jtkohl"},
! {0, 4, "root"},
};
krb5_data *princ[] = {&string_list[0], &string_list[1], &string_list[2], 0};
krb5_data string_list2[3] = {
! {0, 14, "ATHENA.MIT.EDU"},
! {0, 6, "krbtgt"},
! {0, 14, "ATHENA.MIT.EDU"},
};
krb5_data *princ2[] = {&string_list2[0], &string_list2[1], &string_list2[2], 0};
***************
*** 19,31 ****
krb5_last_req_entry lrentries[] = { {32000, 1}, {0, 3}, {10, 2} };
krb5_last_req_entry *lrfoo1[] = {&lrentries[0], &lrentries[1], &lrentries[2], 0};
! krb5_authdata adarr1[] = { {3, 7, "authdat"}, {2,4,"foob"}, {257,9,"jtkohlxxx"}};
krb5_authdata *authdats[] = {&adarr1[0],&adarr1[1],&adarr1[2],0};
! krb5_pa_data authdarr1[] = { {3, 7, "authdat"}, {2,4,"foob"}, {257,9,"jtkohlxxx"}};
krb5_pa_data *padats[] = {&authdarr1[0],&authdarr1[1],&authdarr1[2],0};
! krb5_address adrarr1[] = { {ADDRTYPE_INET,4,"abcd"},
! {ADDRTYPE_ISO,10,"6176432831"},
! {ADDRTYPE_INET,4,"efgh"} };
krb5_address *addrs[] = {&adrarr1[0],&adrarr1[1],&adrarr1[2],0};
--- 19,31 ----
krb5_last_req_entry lrentries[] = { {32000, 1}, {0, 3}, {10, 2} };
krb5_last_req_entry *lrfoo1[] = {&lrentries[0], &lrentries[1], &lrentries[2], 0};
! krb5_authdata adarr1[3] = { {0, 3, 7, "authdat"}, {0,2,4,"foob"}, {0,257,9,"jtkohlxxx"}};
krb5_authdata *authdats[] = {&adarr1[0],&adarr1[1],&adarr1[2],0};
! krb5_pa_data authdarr1[] = { {0, 3, 7, "authdat"}, {0,2,4,"foob"}, {0,257,9,"jtkohlxxx"}};
krb5_pa_data *padats[] = {&authdarr1[0],&authdarr1[1],&authdarr1[2],0};
! krb5_address adrarr1[] = { {0,ADDRTYPE_INET,4,"abcd"},
! {0,ADDRTYPE_ISO,10,"6176432831"},
! {0,ADDRTYPE_INET,4,"efgh"} };
krb5_address *addrs[] = {&adrarr1[0],&adrarr1[1],&adrarr1[2],0};
2) src/appl/bsd/kcmd.c
Cast the return type of malloc to (char *):
--- kcmd.c Mon Feb 12 14:23:17 1996
***************
*** 108,114 ****
return (-1);
}
! if ((host_save = malloc(strlen(hp->h_name) + 1)) == NULL) {
fprintf(stderr,"kcmd: no memory\n");
return(-1);
}
--- 108,114 ----
return (-1);
}
! if ((host_save = (char *) malloc(strlen(hp->h_name) + 1)) == NULL) {
fprintf(stderr,"kcmd: no memory\n");
return(-1);
}
************************************************************
Sean Mullan Phone: (508) 436-4129
Hewlett-Packard Co. Internet: mullan_s@apollo.hp.com
300 Apollo Drive Fax: (508) 436-5140
Chelmsford, MA 01824
************************************************************
