[1618] in Kerberos-V5-bugs
Re: problem in kdb5_edit.c on Solaris 2.x
daemon@ATHENA.MIT.EDU (Christopher Provenzano)
Thu Sep 7 15:35:56 1995
To: Ed Phillips <flaregun@UDel.Edu>
Cc: krb5-bugs@MIT.EDU
In-Reply-To: Your message of "Thu, 07 Sep 1995 12:18:17 EDT."
<Pine.SOL.3.91.950907120901.1332A-100000@strauss.udel.edu>
Date: Thu, 07 Sep 1995 15:35:33 EDT
From: Christopher Provenzano <proven@MIT.EDU>
>
> There is a problem in the ftime() routine in
> admin/edit/kdb5_edit.c which causes kdb5_edit to get a bus error and dump
> core on Solaris2.X (SC3.0.1 24 Jan 1995). Also, the call to
> gettimeofday() includes a second argument which point to a struct
> timezone. This could be a problem if that is actually used anywhere,
> since Solaris2.X gettimeofday() ignores the second argument.
>
> Here's the patch (just changes the register variable to be a normal
> var... this _should_ be okay to have a register variable here, but it
> breaks):
>
> *** admin/edit/kdb5_edit.c_orig Thu Sep 7 11:22:22 1995
> --- admin/edit/kdb5_edit.c Thu Sep 7 11:49:04 1995
> ***************
> *** 1816,1822 ****
>
> #ifndef HAVE_FTIME
> ftime(tp)
> ! register struct timeb *tp;
> {
> struct timeval t;
> struct timezone tz;
> --- 1816,1822 ----
>
> #ifndef HAVE_FTIME
> ftime(tp)
> ! struct timeb *tp;
> {
> struct timeval t;
> struct timezone tz;
>
>
> +-------------------------------------------------------------------------+
> | Ed Phillips <flaregun@udel.edu> University of Delaware (302) 831-6082 |
> | Jr Systems Programmer, Network and Systems Services, Info. Technologies |
> | Public key footprint: 1C D4 AC C2 A3 D5 97 AA DB 3B D8 85 88 E7 40 B8 |
> | Finger flaregun@udel.edu for PGP public key |
> +-------------------------------------------------------------------------+
>
Since the last release, kdb5_edit.c has gone though some major revisions and
as a result ftime() has been removed and replaced with more portable routines.
Thanks for the patch anyway.
CAP