[15960] in Kerberos-V5-bugs
Re: [krbdev.mit.edu #8661] git commit
daemon@ATHENA.MIT.EDU (Erik Sjölund via RT)
Tue Apr 24 17:20:42 2018
Mail-followup-to: rt@krbdev.mit.edu
mail-copies-to: never
From: "Erik Sjölund via RT" <rt-comment@KRBDEV-PROD-APP-1.mit.edu>
In-Reply-To: <rt-8661@krbdev.mit.edu>
Message-ID: <rt-8661-48431.19.5217362005676@krbdev.mit.edu>
To: "'AdminCc of krbdev.mit.edu Ticket #8661'":;
Date: Tue, 24 Apr 2018 17:20:34 -0400 (EDT)
Reply-To: rt-comment@KRBDEV-PROD-APP-1.mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krb5-bugs-bounces@mit.edu
A comment regarding the git commit:
https://github.com/krb5/krb5/commit/c5b0a998d6349f8c90821a347db5666aed0e50eb
The check for argc == 0 happens after the first use of argv[0].
Why not place the if statement right in the start of main()?
On Tue, Apr 24, 2018 at 10:10 PM, Greg Hudson via RT
<rt-comment@krbdev.mit.edu> wrote:
>
> Check for zero argc in ksu
>
> Most programs in the tree will perform a null dereference when argc is
> zero, but as a setuid program ksu should be extra careful about memory
> errors, even if this one is harmless. Check and exit with status 1
> immediately.
>
> https://github.com/krb5/krb5/commit/c5b0a998d6349f8c90821a347db5666aed0e50eb
> Author: Greg Hudson <ghudson@mit.edu>
> Commit: c5b0a998d6349f8c90821a347db5666aed0e50eb
> Branch: master
> src/clients/ksu/main.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
https://mailman.mit.edu/mailman/listinfo/krb5-bugs
