[15938] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

[krbdev.mit.edu #8654] git commit

daemon@ATHENA.MIT.EDU (Greg Hudson via RT)
Mon Apr 9 12:09:28 2018

Mail-followup-to: rt@krbdev.mit.edu
mail-copies-to: never
From: "Greg Hudson via RT" <rt-comment@KRBDEV-PROD-APP-1.mit.edu>
In-Reply-To: <rt-8654@krbdev.mit.edu>
Message-ID: <rt-8654-48382.9.00076873211468@krbdev.mit.edu>
To: "'AdminCc of krbdev.mit.edu Ticket #8654'":;
Date: Mon,  9 Apr 2018 12:09:14 -0400 (EDT)
Reply-To: rt-comment@KRBDEV-PROD-APP-1.mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krb5-bugs-bounces@mit.edu


Restrict pre-authentication fallback cases

Add a new callback disable_fallback() and call it from each clpreauth
module when it generates a client message using credentials to
authenticate.  (For SPAKE, this is the message responding to a
challenge; for all other current mechanisms, it is the first and only
client message.)  If disable_fallback() is called, do not try another
mechanism after a KDC error.

Remove k5_reset_preauth_types_tried() and its call sites, so that
preauth mechanisms which are tried optimistically will no longer be
retried after a failure.

https://github.com/krb5/krb5/commit/7a24a088c16d326127dd2b29084d4ca085c70d10
Author: Greg Hudson <ghudson@mit.edu>
Commit: 7a24a088c16d326127dd2b29084d4ca085c70d10
Branch: master
 src/include/krb5/clpreauth_plugin.h      |   14 +++++
 src/lib/krb5/krb/get_in_tkt.c            |   21 +++-----
 src/lib/krb5/krb/init_creds_ctx.h        |    1 +
 src/lib/krb5/krb/int-proto.h             |    3 -
 src/lib/krb5/krb/preauth2.c              |   23 +++-----
 src/lib/krb5/krb/preauth_ec.c            |    1 +
 src/lib/krb5/krb/preauth_encts.c         |    2 +
 src/lib/krb5/krb/preauth_otp.c           |    4 ++
 src/lib/krb5/krb/preauth_sam2.c          |    1 +
 src/plugins/preauth/pkinit/pkinit_clnt.c |    1 +
 src/plugins/preauth/spake/spake_client.c |    4 ++
 src/plugins/preauth/test/cltest.c        |   11 ++++
 src/tests/t_preauth.py                   |   88 ++++++++++++++++++++++++++----
 src/tests/t_spake.py                     |    9 +---
 14 files changed, 134 insertions(+), 49 deletions(-)

_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
https://mailman.mit.edu/mailman/listinfo/krb5-bugs

home help back first fref pref prev next nref lref last post