[1528] in Kerberos-V5-bugs
Re: bug in krb5.b5 (also krb5.b4) login.krb5
daemon@ATHENA.MIT.EDU (Theodore Ts'o)
Wed Jul 5 20:12:43 1995
Date: Wed, 5 Jul 1995 20:11:39 +0500
From: Theodore Ts'o <tytso@MIT.EDU>
To: Jonathan Stone <jonathan@DSG.Stanford.EDU>
Cc: krb5-bugs@MIT.EDU
In-Reply-To: [1510]
Date: Mon, 3 Jul 1995 13:22:40 -0700
From: Jonathan Stone <jonathan@DSG.Stanford.EDU>
src/appl/bsd/login.c calls TIOCLSET when it's using a POSIX
termios interface. This loses on (old) Ultrix systems,
of which there seem to be many here.
Yup; TIOCLSET should never be used if POSIX_TERMIOS is defined.
In general, though, using TIOCLSET with termios _anywhere_ doesn't
seem right to me. TIOCLSET is clearly, nay, indubitably part of the
BSD (7th edition?) terminal interface, not termios or termio.
Actually, it's part of the BSD 4.3 interface. It's not clear to me that
it's worth preserving the ability to work with systems that only support
the BSD 4.[23] tty interface, but I've left this code in for now. We
reserve the right go back later on and rip it all out, in the interests
of increasing code maintainability and readability, though.
Is TIOCNXCL a potential problem? I can't find it in 1003.1-1988,
but I think it dates back to v7 and even Linux has it; maybe I need
to get an up-to-date 1003.1 spec.
It may be; on the other hand, if the system has TIOCNXCL, it's probably
safe to call it, since there isn't an explicit POSIX replacement for
TIOCNXCL.
Thanks for the bug report!
- Ted
