[1296] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

Re: krlogin encryption problem

daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Sun Mar 26 10:02:46 1995

From: "Jonathan I. Kamens" <jik@cam.ov.com>
Date: Sun, 26 Mar 1995 10:06:00 -0500
To: John DiMarco <jdd@cdf.toronto.edu>
Cc: krb5-bugs@MIT.EDU
In-Reply-To: [1293]

FYI, here's John DiMarco's fix, against krb5b4pl3 plus the patches
we've sent in for krlogin.c:

--- krlogin.c	1995/03/24 19:05:44	1.15
+++ krlogin.c	1995/03/26 14:59:25
@@ -1616,7 +1616,7 @@
 #endif
 		/* XXX can't read enough, pipe
 		   must have closed */
-	return(0);
+	return(-1);
     }
     rd_len = ntohl(rd_len);
     net_len = krb5_encrypt_size(rd_len,eblock.crypto_entry);
@@ -1624,7 +1624,7 @@
 	/* preposterous length; assume out-of-sync; only
 	   recourse is to close connection, so return 0 */
 	fprintf(stderr,"%s: Read size problem.\n", progname);
-	return(0);
+	return(-1);
     }
     if ((cc = krb5_net_read(fd, desinbuf.data, net_len)) != net_len) {
 	/* pipe must have closed, return 0 */
@@ -1631,7 +1631,7 @@
 	fprintf(stderr,
 		"%s: Read error: length received %d != expected %d.\n",
 		progname, cc,net_len);
-	return(0);
+	return(-1);
     }
     /* decrypt info */
     if ((krb5_decrypt(desinbuf.data,
@@ -1639,7 +1639,7 @@
 		      net_len,
 		      &eblock, 0))) {
 	fprintf(stderr,"%s: Cannot decrypt data from network.\n", progname);
-	return(0);
+	return(-1);
     }
     store_ptr = storage;
     nstored = rd_len;

home help back first fref pref prev next nref lref last post